linux-kernel - Re: [PATCH] selftests/x86: Add selftests include path for kselftest.h after centralization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DFMJF68KIIHN.3Y2YF3EXRJ53@google.com>
Date: Mon, 12 Jan 2026 10:27:15 +0000
From: Brendan Jackman <jackmanb@...gle.com>
To: Bala-Vignesh-Reddy <reddybalavignesh9979@...il.com>, <naresh.kamboju@...aro.org>, 
	<broonie@...nel.org>, <bp@...en8.de>, <shuah@...nel.org>
Cc: <anders.roxell@...aro.org>, <arnd@...db.de>, 
	<benjamin.copeland@...aro.org>, <bp@...en8.de>, <dan.carpenter@...aro.org>, 
	<dave.hansen@...ux.intel.com>, <hpa@...or.com>, 
	<linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>, 
	<lkft-triage@...ts.linaro.org>, <mingo@...hat.com>, 
	<regressions@...ts.linux.dev>, <richard.weiyang@...il.com>, 
	<shuah@...nel.org>, <surenb@...gle.com>, <tglx@...utronix.de>, 
	<x86@...nel.org>, <linux-kernel-mentees@...ts.linux.dev>, 
	Linux Kernel Functional Testing <lkft@...aro.org>
Subject: Re: [PATCH] selftests/x86: Add selftests include path for kselftest.h
 after centralization

On Wed Oct 22, 2025 at 6:29 AM UTC, Bala-Vignesh-Reddy wrote:
> The previous change centralizing kselftest.h include path in lib.mk
> caused x86 selftests to fail, as x86 Makefile overwrites CFLAGS using
> ":=", dropping the include path added in lib.mk. Therefore, helpers.h
> could not find kselftest.h during compilation.
>
> Fix this by adding the tools/testing/sefltest to CFLAGS in x86 Makefile.
>
> Fixes: 4d89827dfb27 ("selftests: complete kselftest include centralization")
> Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
> Closes: https://lore.kernel.org/lkml/CA+G9fYvKjQcCBMfXA-z2YuL2L+3Qd-pJjEUDX8PDdz2-EEQd=Q@mail.gmail.com/T/#m83fd330231287fc9d6c921155bee16c591db7360
>
> Signed-off-by: Bala-Vignesh-Reddy <reddybalavignesh9979@...il.com>

Thanks, this fixes the issue I reported here:

https://lore.kernel.org/lkml/DFHI984SEFV3.2JL88CLHNT2SO@google.com/

Tested-by: Brendan Jackman <jackmanb@...gle.com>

Shuah, does this go via the kselftests tree? If not, Boris can you take
it via x86?