linux-kernel - Re: [PATCH v2 2/3] mfd: rk8xx: Add RK801 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1242f7d2-e68c-42ca-a6cc-c56c9e6a496f@rock-chips.com>
Date: Mon, 12 Jan 2026 20:29:04 +0800
From: Joseph Chen <chenjh@...k-chips.com>
To: Heiko Stübner <heiko@...ech.de>,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Lee Jones <lee@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v2 2/3] mfd: rk8xx: Add RK801 support


在 2026/1/12 19:02, Heiko Stübner 写道:
> Hi Joseph,
>
> Am Montag, 12. Januar 2026, 11:28:48 Mitteleuropäische Normalzeit schrieb Joseph Chen:
>> The RK801 is a Power Management IC (PMIC) for multimedia
>> and handheld devices. It contains the following components:
>>
>> - 4 BUCK
>> - 2 LDO
>> - 1 SWITCH
>>
>> Signed-off-by: Joseph Chen <chenjh@...k-chips.com>
>> ---
>>   drivers/mfd/Kconfig                 |    6 +-
>>   drivers/mfd/rk8xx-core.c            |   81 ++
>>   drivers/mfd/rk8xx-i2c.c             |   33 +-
>>   drivers/regulator/rk808-regulator.c | 1963 ---------------------------
>>   include/linux/mfd/rk808.h           |  118 ++
>>   5 files changed, 234 insertions(+), 1967 deletions(-)
>>   delete mode 100644 drivers/regulator/rk808-regulator.c
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 6cec1858947..5405e8633aa 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -1355,15 +1355,15 @@ config MFD_RK8XX
>>   	select MFD_CORE
>>   
>>   config MFD_RK8XX_I2C
>> -	tristate "Rockchip RK805/RK808/RK809/RK816/RK817/RK818 Power Management Chip"
>> +	tristate "Rockchip RK801/RK805/RK808/RK809/RK816/RK817/RK818 Power Management Chip"
> nit: I think at some point it'd be time to make that
> 	"Rockchip RX8xx Power Management Chips"
> The config entry is already named that way, and that list of individual
> supported chips gets way too long.
>
> Also the individual supported chips _are_ listed below, so the unwieldy
> entry headline can be shortened.

Thanks, agreed. Will fix in v3.

>>   	depends on I2C && OF
>>   	select MFD_CORE
>>   	select REGMAP_I2C
>>   	select REGMAP_IRQ
>>   	select MFD_RK8XX
>>   	help
>> -	  If you say yes here you get support for the RK805, RK808, RK809,
>> -	  RK816, RK817 and RK818 Power Management chips.
>> +	  If you say yes here you get support for the RK801, RK805, RK808,
>> +	  RK809, RK816, RK817 and RK818 Power Management chips.
>>   	  This driver provides common support for accessing the device
>>   	  through I2C interface. The device supports multiple sub-devices
>>   	  including interrupts, RTC, LDO & DCDC regulators, and onkey.
> [...]
>
>> diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
>> deleted file mode 100644
>> index 1e814247965..00000000000
>> --- a/drivers/regulator/rk808-regulator.c
>> +++ /dev/null
> Looks like something did go wrong here, as you're removing the whole
> drivers/regulator/rk808-regulator.c file from the MFD patch.
>
>
> Thanks
> Heiko
>
>
>
Thanks for catching this. It was a silly mistake on my end during local
patch preparation.
I'll send a v3 shortly to fix this issue to avoid wasting reviewers' time.

-- 
Best regards,
Joseph Chen