linux-kernel - Re: [PATCH] dt-bindings: hwmon: Convert aspeed,ast2400-pwm-tacho to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d63c13e-15d2-4555-a110-4d446f3db314@roeck-us.net>
Date: Mon, 12 Jan 2026 16:00:25 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Andrew Jeffery <andrew@...econstruct.com.au>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
	linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: Convert aspeed,ast2400-pwm-tacho to
 DT schema

On Fri, Jan 09, 2026 at 04:40:28PM +1030, Andrew Jeffery wrote:
> From: "Rob Herring (Arm)" <robh@...nel.org>
> 
> Convert the ASpeed fan controller binding to DT schema format.
> 
> The '#size-cells' value is 0 rather 1.
> 
> Some users define more that 8 fan nodes where 2 fans share a PWM. The
> driver seems to let the 2nd fan just overwrite the 1st one. That also
> creates some addressing errors in the DT (duplicate addresses and wrong
> unit-addresses).
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> Acked-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Andrew Jeffery <andrew@...econstruct.com.au>
> ---
> Hello,
> 
> This change has been on a bit of a journey[1][2] and was eventually
> integrated into my RFC series tidying up the AST2600 EVB at [3]. Rob
> did some further digging at [4] and I've now addressed his finding
> there.
> 
> Much of the series at [3] was merged so I'm splitting out what remains
> and peeling off the RFC label after making necessary fixes.
> 
> Guenter - I've included your A-b tag from [3], but as I'm sending this
> to be applied through the hwmon tree, do with that as you please.
> 
> Changes since the series at [3]:
> - Update #cooling-cells to 2 based on Rob's observation at [4]
> 

Applied.

Thanks,
Guenter