linux-kernel - Re: [PATCH] media: saa7134: rename i2c_dbg() to i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWY3HAZUhTr829qJ@ninjato>
Date: Tue, 13 Jan 2026 13:14:20 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: saa7134: rename i2c_dbg() to i2c_debug()

On Tue, Jan 13, 2026 at 12:57:53PM +0100, Bartosz Golaszewski wrote:
> Ahead of introducing I2C-adapter-specific printk() helpers, preemptively
> avoid a conflict with the upcoming i2c_dbg() and rename the local macro
> in the saa7134 driver to i2c_debug().
> 
> Suggested-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
> ---
> We've started working on changes to i2c core that should allow us to
> eventually address the object-lifetime issues[1] in the subsystem. One of
> the prerequisite steps is to hide all dereferences of struct device
> embedded in struct i2c_adapter with dedicated wrappers. To that end, we
> want to introduce a set of i2c_adapter-specific printk() helpers[2]. The
> name i2c_dbg() conflicted with the macro defined in this driver[3].
> Wolfram suggested[4] that since the i2c changes will not make v7.0, it's
> worth renaming the macro here to free up the shorter name for a use-case
> where there'll be a lot more users. It would be great if this could make
> the v7.0 merge window.

True all that. If we can't have it in 7.0 an ack from media maintainers
would also be great. Then, we can carry it with Bart's series and keep
dependencies low. This is really just a simple rename.

> -#define i2c_dbg(level, fmt, arg...) do { \
> +#define i2c_debug(level, fmt, arg...) do { \

To avoid future issues, I would suggest 'saa7134_i2c_dbg' to have the
namespace clear. But in general,

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>