lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87ecntr9c5.wl-tiwai@suse.de>
Date: Tue, 13 Jan 2026 13:22:18 +0100
From: Takashi Iwai <tiwai@...e.de>
To: fenugrec@...l.com
Cc: linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	roy.vegard.ovesen@...il.com,
	mickflemm@...il.com
Subject: Re: [PATCH v2 0/2] ALSA: usb-audio: presonus s1810 minor cleanup and document

On Sun, 11 Jan 2026 22:36:39 +0100,
fenugrec via B4 Relay wrote:
> 
> patch v2 : apologies, I had missed an __le32 field.
> 
> - Use __le32 fields for structures sent/received over USB
>  Addresses a comment from when this driver was initially merged:
>   https://lore.kernel.org/all/s5hd0agcjw1.wl-tiwai@suse.de/
> 
> - Document constants and protocol details common to the Studio 1810 and
> 1824c devices
> 
> Except for a hypothetical big-endian platform (which I cannot test) where the first
> commit would make a difference, both these should have no functional
> change.
> 
> Signed-off-by: fenugrec <fenugrec@...l.com>
> ---
> Changes in v2:
> - fix an overlooked __le32 conversion for .tag and .len fields
> - Link to v1: https://lore.kernel.org/r/20260110-preso_clean1-v1-0-ce2dd3ea4506@mail.com

Thanks for the patches.  The code changes look OK, so I can take as
is.

But I wonder about your identity "fenugrec".  Is it a real name?
The Signed-off-by line needs to be a real name (or a known identity) 
for legal reasons.


thanks,

Takashi

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ