linux-kernel - Re: [PATCH] ALSA: hda/cirrus_scodec_test: Fix incorrect setup of gpiochip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zf6hpscg.wl-tiwai@suse.de>
Date: Tue, 13 Jan 2026 14:14:39 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	patches@...nsource.cirrus.com
Subject: Re: [PATCH] ALSA: hda/cirrus_scodec_test: Fix incorrect setup of gpiochip

On Tue, 13 Jan 2026 14:09:54 +0100,
Richard Fitzgerald wrote:
> 
> Set gpiochip parent to the struct device of the dummy GPIO driver
> so that the software node will be associated with the GPIO chip.
> 
> The recent commit e5d527be7e698 ("gpio: swnode: don't use the
> swnode's name as the key for GPIO lookup") broke cirrus_scodec_test,
> because the software node no longer gets associated with the GPIO
> driver by name.
> 
> Instead, setting struct gpio_chip.parent to the owning struct device
> will find the node using a normal fwnode lookup.
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> Fixes: 2144833e7b414 ("ALSA: hda: cirrus_scodec: Add KUnit test")

Applied now.  Thanks.


Takashi