linux-kernel - [PATCH rdma-next] IB/mlx5: Fix port speed query for representors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260113-port-speed-query-fix-v1-1-234cacc991fa@nvidia.com>
Date: Tue, 13 Jan 2026 15:31:26 +0200
From: Edward Srouji <edwards@...dia.com>
To: Leon Romanovsky <leon@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>, "Mark
 Bloch" <mbloch@...dia.com>, Saeed Mahameed <saeedm@...dia.com>, Roi Dayan
	<roid@...dia.com>
CC: <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Or Har-Toov
	<ohartoov@...dia.com>, Edward Srouji <edwards@...dia.com>
Subject: [PATCH rdma-next] IB/mlx5: Fix port speed query for representors

From: Or Har-Toov <ohartoov@...dia.com>

When querying speed information for a representor in switchdev mode,
the code previously used the first device in the eswitch, which may not
match the device that actually owns the representor. In setups such as
multi-port eswitch or LAG, this led to incorrect port attributes being
reported.

Fix this by retrieving the correct core device from the representor's
eswitch before querying its port attributes.

Fixes: 27f9e0ccb6da ("net/mlx5: Lag, Add single RDMA device in multiport mode")
Signed-off-by: Or Har-Toov <ohartoov@...dia.com>
Reviewed-by: Mark Bloch <mbloch@...dia.com>
Signed-off-by: Edward Srouji <edwards@...dia.com>
---
 drivers/infiniband/hw/mlx5/main.c | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index e81080622283..d0c6648ee035 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -561,12 +561,23 @@ static int mlx5_query_port_roce(struct ib_device *device, u32 port_num,
 	 * of an error it will still be zeroed out.
 	 * Use native port in case of reps
 	 */
-	if (dev->is_rep)
-		err = mlx5_query_port_ptys(mdev, out, sizeof(out), MLX5_PTYS_EN,
-					   1, 0);
-	else
-		err = mlx5_query_port_ptys(mdev, out, sizeof(out), MLX5_PTYS_EN,
-					   mdev_port_num, 0);
+	if (dev->is_rep) {
+		struct mlx5_eswitch_rep *rep;
+		struct mlx5_core_dev *esw_mdev;
+
+		rep = dev->port[port_num - 1].rep;
+		if (rep) {
+			esw_mdev = mlx5_eswitch_get_core_dev(rep->esw);
+			if (esw_mdev)
+				mdev = esw_mdev;
+		}
+
+		mdev_port_num = 1;
+	}
+
+	err = mlx5_query_port_ptys(mdev, out, sizeof(out), MLX5_PTYS_EN,
+				   mdev_port_num, 0);
+
 	if (err)
 		goto out;
 	ext = !!MLX5_GET_ETH_PROTO(ptys_reg, out, true, eth_proto_capability);

---
base-commit: 325e3b5431ddd27c5f93156b36838a351e3b2f72
change-id: 20260113-port-speed-query-fix-592efa2b4e36

Best regards,
-- 
Edward Srouji <edwards@...dia.com>