linux-kernel - Re: [PATCH] ALSA: usb-audio: Prevent excessive number of frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ldi1ppyk.wl-tiwai@suse.de>
Date: Tue, 13 Jan 2026 15:06:11 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Edward Adam Davis <eadavis@...com>
Cc: syzbot+6db0415d6d5c635f72cb@...kaller.appspotmail.com,
	linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org,
	linux-usb@...r.kernel.org,
	perex@...ex.cz,
	syzkaller-bugs@...glegroups.com,
	tiwai@...e.com
Subject: Re: [PATCH] ALSA: usb-audio: Prevent excessive number of frames

On Tue, 13 Jan 2026 09:29:23 +0100,
Edward Adam Davis wrote:
> 
> In this case, the user constructed the parameters with maxpacksize 40
> for rate 22050 / pps 1000, and packsize[0] 22 packsize[1] 23. The buffer
> size for each data URB is maxpacksize * packets, which in this example
> is 40 * 6 = 240; When the user performs a write operation to send audio
> data into the ALSA PCM playback stream, the calculated number of frames
> is packsize[0] * packets = 264, which exceeds the allocated URB buffer
> size, triggering the out-of-bounds (OOB) issue reported by syzbot [1].
> 
> Added a check for the number of single data URB frames when calculating
> the number of frames to prevent [1].
> 
> [1]
> BUG: KASAN: slab-out-of-bounds in copy_to_urb+0x261/0x460 sound/usb/pcm.c:1487
> Write of size 264 at addr ffff88804337e800 by task syz.0.17/5506
> Call Trace:
>  copy_to_urb+0x261/0x460 sound/usb/pcm.c:1487
>  prepare_playback_urb+0x953/0x13d0 sound/usb/pcm.c:1611
>  prepare_outbound_urb+0x377/0xc50 sound/usb/endpoint.c:333
> 
> Reported-by: syzbot+6db0415d6d5c635f72cb@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=6db0415d6d5c635f72cb
> Tested-by: syzbot+6db0415d6d5c635f72cb@...kaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@...com>

Applied now.  Thanks.


Takashi