linux-kernel - Re: [PATCH 0/3] selftests/mm: add memory failure selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWZRKk92pYvwBLj6@rli9-mobl>
Date: Tue, 13 Jan 2026 22:05:30 +0800
From: Philip Li <philip.li@...el.com>
To: "David Hildenbrand (Red Hat)" <david@...nel.org>
CC: Miaohe Lin <linmiaohe@...wei.com>, <lorenzo.stoakes@...cle.com>,
	<Liam.Howlett@...cle.com>, <vbabka@...e.cz>, <rppt@...nel.org>,
	<surenb@...gle.com>, <mhocko@...e.com>, <nao.horiguchi@...il.com>,
	<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <akpm@...ux-foundation.org>,
	<shuah@...nel.org>
Subject: Re: [PATCH 0/3] selftests/mm: add memory failure selftests

On Mon, Jan 12, 2026 at 08:38:58PM +0100, David Hildenbrand (Red Hat) wrote:
> On 1/12/26 13:44, Miaohe Lin wrote:
> > On 2026/1/12 19:33, Miaohe Lin wrote:

...

> > > > > > # # # Starting 6 tests from 2 test cases.
> > > > > > # # #  RUN           memory_failure.madv_hard.anon ...
> > > > > > # # #            OK  memory_failure.madv_hard.anon
> > > > > > # not ok 71 memory-failure # exit=1
> > > > > > 
> > > > > > 
> > > > > > Can the test maybe not deal with running in certain environments (config options etc)?
> > > > > 
> > > > > To run the test, I think there should be:
> > > > >     1.CONFIG_MEMORY_FAILURE and CONFIG_HWPOISON_INJECT should be enabled.

in 0day env, the configs are below

CONFIG_MEMORY_FAILURE=y
CONFIG_HWPOISON_INJECT=m

> > > > >     2.Root privilege is required.

yes, use root to run

> > > > >     3.For dirty/clean pagecache testcases, the test file "./clean-page-cache-test-file" and
> > > > >       "./dirty-page-cache-test-file" are assumed to be created on non-memory file systems
> > > > >       such as xfs, ext4, etc.

this is a problem in 0day, the test is running in tmpfs. Let me further check
to correct this.

> > > > > 
> > > > > Does your test environment break any of the above rules?
> > > > 
> > > > It is 0day environment, so very likely yes. I suspect 1).
> > 
> > Hi David,
> > 
> > After taking a more close look, I think CONFIG_MEMORY_FAILURE and CONFIG_HWPOISON_INJECT should have been
> > enabled in 0day environment or testcase memory_failure.madv_hard.anon should fail. memory_failure.madv_hard.anon
> > will inject memory failure and expects seeing a SIGBUG signal.
> 
> Good point.
> 
> > 
> > > > 
> > > > > Am I expected to add some code to
> > > > > guard against this?
> > > > 
> > > > Yes, at least some.
> > > > 
> > > > Checking for root privileges is not required. The tests are commonly run from non-memory file systems, but, in theory, could be run from nfs etc.
> > > > 
> > > > If you require special file systems, take a look at gup_longterm.o where we test for some fileystsem types.
> > 
> > And I think the cause of failures of testcases memory_failure.madv_hard.clean_pagecache and memory_failure.madv_hard.dirty_pagecache
> > is they running on memory filesystems. The error pages are kept in page cache in that case while memory_failure.madv_hard.clean_pagecache
> > expects to see the error page truncated.
> 
> Maybe they are run on shmem? Good question. (@Phil?)

yes, it runs on tmpfs, let me further check to resolve it.

> 
> > 
> > But I have no idea why memory_failure.madv_soft.dirty_pagecache and memory_failure.madv_soft.clean_pagecache return -1(-EPERM?) when try
> > to inject memory error through madvise syscall. It could be really helpful if more information can be provided.
> 
> Here is more information:
> 
> https://download.01.org/0day-ci/archive/20260110/202601100241.326d7cce-lkp@intel.com
> 
> Unfortunately no config yet. (@Phil, could we provide that one as well as
> part of that bundle?)

Got it, i will update the script to upload the kernel kconfig.

> 
> -- 
> Cheers
> 
> David