| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202601132207.vbf56Uh9-lkp@intel.com>
Date: Tue, 13 Jan 2026 22:14:26 +0800
From: kernel test robot <lkp@...el.com>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev,
"Gustavo A. R. Silva" <gustavo@...eddedor.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: [gustavoars:testing/wfamnae-next20260113 7/16]
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1002:32: error: invalid application of
'sizeof' to incomplete type 'struct ssp_command_iu'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/wfamnae-next20260113
head: 52754522a0ac00706210372e66bc73f60fa759d2
commit: 2f3d1d884e953f07b26e97dced8ba1b7adba61ad [7/16] scsi: libsas/aci94xx: Avoid multiple -Wflex-array-member-not-at-end warnings
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260113/202601132207.vbf56Uh9-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260113/202601132207.vbf56Uh9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601132207.vbf56Uh9-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/scsi/hisi_sas/hisi_sas_main.c:7:
>> drivers/scsi/hisi_sas/hisi_sas.h:617:47: error: field 'task' has incomplete type
617 | struct ssp_command_iu task;
| ^~~~
--
In file included from drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:7:
>> drivers/scsi/hisi_sas/hisi_sas.h:617:47: error: field 'task' has incomplete type
617 | struct ssp_command_iu task;
| ^~~~
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c: In function 'prep_ssp_v1_hw':
>> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1002:32: error: invalid application of 'sizeof' to incomplete type 'struct ssp_command_iu'
1002 | dw2 = ((sizeof(struct ssp_command_iu) +
| ^~~~~~
--
In file included from drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:7:
>> drivers/scsi/hisi_sas/hisi_sas.h:617:47: error: field 'task' has incomplete type
617 | struct ssp_command_iu task;
| ^~~~
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c: In function 'prep_ssp_v2_hw':
>> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:1779:25: error: invalid application of 'sizeof' to incomplete type 'struct ssp_command_iu'
1779 | dw2 = (((sizeof(struct ssp_command_iu) + sizeof(struct ssp_frame_hdr)
| ^~~~~~
vim +1002 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
42e7a69368a585 John Garry 2015-11-18 950
a2b3820bddfbff Xiang Chen 2018-05-09 951 static void prep_ssp_v1_hw(struct hisi_hba *hisi_hba,
78bd2b4f6e7c05 Xiaofei Tan 2018-05-21 952 struct hisi_sas_slot *slot)
42e7a69368a585 John Garry 2015-11-18 953 {
42e7a69368a585 John Garry 2015-11-18 954 struct sas_task *task = slot->task;
42e7a69368a585 John Garry 2015-11-18 955 struct hisi_sas_cmd_hdr *hdr = slot->cmd_hdr;
42e7a69368a585 John Garry 2015-11-18 956 struct domain_device *device = task->dev;
42e7a69368a585 John Garry 2015-11-18 957 struct hisi_sas_device *sas_dev = device->lldd_dev;
42e7a69368a585 John Garry 2015-11-18 958 struct hisi_sas_port *port = slot->port;
42e7a69368a585 John Garry 2015-11-18 959 struct sas_ssp_task *ssp_task = &task->ssp_task;
42e7a69368a585 John Garry 2015-11-18 960 struct scsi_cmnd *scsi_cmnd = ssp_task->cmd;
bbfe82cdbaf84e John Garry 2022-02-17 961 struct sas_tmf_task *tmf = slot->tmf;
78bd2b4f6e7c05 Xiaofei Tan 2018-05-21 962 int has_data = 0, priority = !!tmf;
ebf26e93cfece2 John Garry 2023-08-15 963 u8 *buf_cmd;
42e7a69368a585 John Garry 2015-11-18 964 u32 dw1, dw2;
42e7a69368a585 John Garry 2015-11-18 965
42e7a69368a585 John Garry 2015-11-18 966 /* create header */
42e7a69368a585 John Garry 2015-11-18 967 hdr->dw0 = cpu_to_le32((1 << CMD_HDR_RESP_REPORT_OFF) |
42e7a69368a585 John Garry 2015-11-18 968 (0x2 << CMD_HDR_TLR_CTRL_OFF) |
42e7a69368a585 John Garry 2015-11-18 969 (port->id << CMD_HDR_PORT_OFF) |
42e7a69368a585 John Garry 2015-11-18 970 (priority << CMD_HDR_PRIORITY_OFF) |
42e7a69368a585 John Garry 2015-11-18 971 (1 << CMD_HDR_MODE_OFF) | /* ini mode */
42e7a69368a585 John Garry 2015-11-18 972 (1 << CMD_HDR_CMD_OFF)); /* ssp */
42e7a69368a585 John Garry 2015-11-18 973
42e7a69368a585 John Garry 2015-11-18 974 dw1 = 1 << CMD_HDR_VERIFY_DTL_OFF;
42e7a69368a585 John Garry 2015-11-18 975
78bd2b4f6e7c05 Xiaofei Tan 2018-05-21 976 if (tmf) {
42e7a69368a585 John Garry 2015-11-18 977 dw1 |= 3 << CMD_HDR_SSP_FRAME_TYPE_OFF;
42e7a69368a585 John Garry 2015-11-18 978 } else {
42e7a69368a585 John Garry 2015-11-18 979 switch (scsi_cmnd->sc_data_direction) {
42e7a69368a585 John Garry 2015-11-18 980 case DMA_TO_DEVICE:
42e7a69368a585 John Garry 2015-11-18 981 dw1 |= 2 << CMD_HDR_SSP_FRAME_TYPE_OFF;
42e7a69368a585 John Garry 2015-11-18 982 has_data = 1;
42e7a69368a585 John Garry 2015-11-18 983 break;
42e7a69368a585 John Garry 2015-11-18 984 case DMA_FROM_DEVICE:
42e7a69368a585 John Garry 2015-11-18 985 dw1 |= 1 << CMD_HDR_SSP_FRAME_TYPE_OFF;
42e7a69368a585 John Garry 2015-11-18 986 has_data = 1;
42e7a69368a585 John Garry 2015-11-18 987 break;
42e7a69368a585 John Garry 2015-11-18 988 default:
42e7a69368a585 John Garry 2015-11-18 989 dw1 |= 0 << CMD_HDR_SSP_FRAME_TYPE_OFF;
42e7a69368a585 John Garry 2015-11-18 990 }
42e7a69368a585 John Garry 2015-11-18 991 }
42e7a69368a585 John Garry 2015-11-18 992
42e7a69368a585 John Garry 2015-11-18 993 /* map itct entry */
42e7a69368a585 John Garry 2015-11-18 994 dw1 |= sas_dev->device_id << CMD_HDR_DEVICE_ID_OFF;
42e7a69368a585 John Garry 2015-11-18 995 hdr->dw1 = cpu_to_le32(dw1);
42e7a69368a585 John Garry 2015-11-18 996
78bd2b4f6e7c05 Xiaofei Tan 2018-05-21 997 if (tmf) {
42e7a69368a585 John Garry 2015-11-18 998 dw2 = ((sizeof(struct ssp_tmf_iu) +
42e7a69368a585 John Garry 2015-11-18 999 sizeof(struct ssp_frame_hdr)+3)/4) <<
42e7a69368a585 John Garry 2015-11-18 1000 CMD_HDR_CFL_OFF;
42e7a69368a585 John Garry 2015-11-18 1001 } else {
42e7a69368a585 John Garry 2015-11-18 @1002 dw2 = ((sizeof(struct ssp_command_iu) +
42e7a69368a585 John Garry 2015-11-18 1003 sizeof(struct ssp_frame_hdr)+3)/4) <<
42e7a69368a585 John Garry 2015-11-18 1004 CMD_HDR_CFL_OFF;
42e7a69368a585 John Garry 2015-11-18 1005 }
42e7a69368a585 John Garry 2015-11-18 1006
42e7a69368a585 John Garry 2015-11-18 1007 dw2 |= (HISI_SAS_MAX_SSP_RESP_SZ/4) << CMD_HDR_MRFL_OFF;
42e7a69368a585 John Garry 2015-11-18 1008
42e7a69368a585 John Garry 2015-11-18 1009 hdr->transfer_tags = cpu_to_le32(slot->idx << CMD_HDR_IPTT_OFF);
42e7a69368a585 John Garry 2015-11-18 1010
a2b3820bddfbff Xiang Chen 2018-05-09 1011 if (has_data)
a2b3820bddfbff Xiang Chen 2018-05-09 1012 prep_prd_sge_v1_hw(hisi_hba, slot, hdr, task->scatter,
42e7a69368a585 John Garry 2015-11-18 1013 slot->n_elem);
42e7a69368a585 John Garry 2015-11-18 1014
42e7a69368a585 John Garry 2015-11-18 1015 hdr->data_transfer_len = cpu_to_le32(task->total_xfer_len);
f557e32c0023ea Xiaofei Tan 2017-06-29 1016 hdr->cmd_table_addr = cpu_to_le64(hisi_sas_cmd_hdr_addr_dma(slot));
f557e32c0023ea Xiaofei Tan 2017-06-29 1017 hdr->sts_buffer_addr = cpu_to_le64(hisi_sas_status_buf_addr_dma(slot));
42e7a69368a585 John Garry 2015-11-18 1018
f557e32c0023ea Xiaofei Tan 2017-06-29 1019 buf_cmd = hisi_sas_cmd_hdr_addr_mem(slot) +
f557e32c0023ea Xiaofei Tan 2017-06-29 1020 sizeof(struct ssp_frame_hdr);
42e7a69368a585 John Garry 2015-11-18 1021 hdr->dw2 = cpu_to_le32(dw2);
42e7a69368a585 John Garry 2015-11-18 1022
42e7a69368a585 John Garry 2015-11-18 1023 memcpy(buf_cmd, &task->ssp_task.LUN, 8);
78bd2b4f6e7c05 Xiaofei Tan 2018-05-21 1024 if (!tmf) {
4dc051eb0c6b6c John Garry 2023-08-15 1025 buf_cmd[9] = task->ssp_task.task_attr;
42e7a69368a585 John Garry 2015-11-18 1026 memcpy(buf_cmd + 12, task->ssp_task.cmd->cmnd,
42e7a69368a585 John Garry 2015-11-18 1027 task->ssp_task.cmd->cmd_len);
42e7a69368a585 John Garry 2015-11-18 1028 } else {
42e7a69368a585 John Garry 2015-11-18 1029 buf_cmd[10] = tmf->tmf;
42e7a69368a585 John Garry 2015-11-18 1030 switch (tmf->tmf) {
42e7a69368a585 John Garry 2015-11-18 1031 case TMF_ABORT_TASK:
42e7a69368a585 John Garry 2015-11-18 1032 case TMF_QUERY_TASK:
42e7a69368a585 John Garry 2015-11-18 1033 buf_cmd[12] =
42e7a69368a585 John Garry 2015-11-18 1034 (tmf->tag_of_task_to_be_managed >> 8) & 0xff;
42e7a69368a585 John Garry 2015-11-18 1035 buf_cmd[13] =
42e7a69368a585 John Garry 2015-11-18 1036 tmf->tag_of_task_to_be_managed & 0xff;
42e7a69368a585 John Garry 2015-11-18 1037 break;
42e7a69368a585 John Garry 2015-11-18 1038 default:
42e7a69368a585 John Garry 2015-11-18 1039 break;
42e7a69368a585 John Garry 2015-11-18 1040 }
42e7a69368a585 John Garry 2015-11-18 1041 }
42e7a69368a585 John Garry 2015-11-18 1042 }
42e7a69368a585 John Garry 2015-11-18 1043
:::::: The code at line 1002 was first introduced by commit
:::::: 42e7a69368a5855b36cbaff130e58e2cc9976ff3 hisi_sas: Add ssp command function
:::::: TO: John Garry <john.garry@...wei.com>
:::::: CC: Martin K. Petersen <martin.petersen@...cle.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists