linux-kernel - Re: [PATCH v2 0/2] irqchip: convert ls-extirq to a platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21ho6KN8Ro1HDJAqBGPiWDw+QHUcaRme-XTxRcNAV3DuKqw@mail.gmail.com>
Date: Tue, 13 Jan 2026 17:33:37 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Ioana Ciornei <ioana.ciornei@....com>, Thomas Gleixner <tglx@...utronix.de>, 
	Alexander Stein <alexander.stein@...tq-group.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Johan Hovold <johan+linaro@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	"Rob Herring (Arm)" <robh@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] irqchip: convert ls-extirq to a platform driver

Hello,

On Fri, 5 Dec 2025 at 17:58, Ioana Ciornei <ioana.ciornei@....com> wrote:
>
> Starting with commit 1b1f04d8271e ("of/irq: Ignore interrupt parent for
> nodes without interrupts"), the ls-extirq stopped working. This is
> because ls-extirq, being one of the interrupt-map property abusers,
> does not pass the dt checks added by the referenced commit, making it
> unable to determine its interrupt parent.
>
> Instead of reverting the referenced commit, convert the ls-extirq to a
> platform driver so that we avoid completely the irqchip_init() ->
> of_irq_init() code path. This is what patch 1/2 does.
>
> Patch 2/2 makes the parent dt nodes of ls-extirq to get probed by the
> simple-pm-bus driver, for the single goal of it running
> of_platform_populate(). Without this patch, the simple-pm-bus will not
> get to probe on the ls-extirq nodes.
>
> Alternative fixup routes were discussed in the following thread.
> https://lore.kernel.org/all/CAL_JsqJ4q2=UJbuhfbvsbr2T+SRGXsPSXCLk6iXZid_qwYrN4g@mail.gmail.com/
>
> Changes in v2:
> - Use builtin_platform_driver since the driver cannot be built as a
>   module
>
> Ioana Ciornei (2):
>   irqchip/ls-extirq: convert to a platform driver
>   bus: simple-pm-bus: probe the Layerscape SCFG node
>
>  drivers/bus/simple-pm-bus.c     |  6 ++++++
>  drivers/irqchip/irq-ls-extirq.c | 32 +++++++++++++++++++++++++++-----
>  2 files changed, 33 insertions(+), 5 deletions(-)
>
> --
> 2.25.1

Tested-by: Vladimir Oltean <vladimir.oltean@....com>

These patches are needed on the LX2160A-RDB, where they fix the following issue:

[    0.000000] irq-ls-extirq: Cannot find parent domain
[    0.000000] OF: of_irq_init: Failed to init
/soc/syscon@...0000/interrupt-controller@14 ((____ptrval____)), parent
0000000000000000
(...)
[   16.372899] mdio_bus 0x0000000008b96000:01: deferred probe timeout,
ignoring dependency
[   16.386223] mdio_bus 0x0000000008b96000:02: deferred probe timeout,
ignoring dependency
[   16.477556] mdio_bus 0x0000000008b96000:00: deferred probe timeout,
ignoring dependency
[   16.567641] mdio_bus 0x0000000008b96000:08: deferred probe timeout,
ignoring dependency
[   16.569071] mdio_bus 0x0000000008b96000:01: deferred probe pending:
mdio_bus: wait for supplier
/soc/syscon@...0000/interrupt-controller@14
[   16.569080] mdio_bus 0x0000000008b96000:02: deferred probe pending:
mdio_bus: wait for supplier
/soc/syscon@...0000/interrupt-controller@14
[   16.569085] mdio_bus 0x0000000008b96000:00: deferred probe pending:
mdio_bus: wait for supplier
/soc/syscon@...0000/interrupt-controller@14
[   16.569090] mdio_bus 0x0000000008b96000:08: deferred probe pending:
mdio_bus: wait for supplier
/soc/syscon@...0000/interrupt-controller@14

I agree with Thomas' comments on patch 1 that the commit message is telling us
the conclusion without telling us what the problem is.

However, between this solution and Alexander's, this is clearly preferable,
because it does not break device trees.

I think this patch set has stalled possibly due to the holiday season, but my
understanding that a v2 is due with an updated commit message and nothing else,
correct?

Thanks,
Vladimir