linux-kernel - Re: [PATCH 2/4] dt-bindings: auxdisplay: Add titanmec,tm1637

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c25d80a-460d-481d-82ae-7d8046750a22@kernel.org>
Date: Tue, 13 Jan 2026 17:24:45 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Siratul Islam <email@...at.me>, andy@...nel.org, geert@...ux-m68k.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: auxdisplay: Add titanmec,tm1637

On 13/01/2026 05:02, Siratul Islam wrote:
> +title: TM1637 7-segment LED display controller
> +
> +maintainers:
> +  - Siratul Islam <email@...at.me>
> +
> +description:
> +  The TM1637 is a 7-segment LED display controller with a two-wire serial
> +  interface. It can drive up to 4 digits and includes brightness control.
> +
> +properties:
> +  compatible:
> +    const: titanmec,tm1637
> +
> +  clk-gpios:
> +    maxItems: 1
> +    description: GPIO for clock line
> +
> +  dio-gpios:
> +    maxItems: 1
> +    description: GPIO for data input/output line

So you are bitbanging in the kernel? This looks too tightly coupled to
the implementation. If this is some sort of standard interface, I would
expect following standard bus-child relationship, like i2c, spi, serial
or even 1-wire.

> +
Best regards,
Krzysztof