linux-kernel - Re: [PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add MaxLinear R(G)MII slew rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWZ57fz3EiwuXh6Y@makrotopia.org>
Date: Tue, 13 Jan 2026 16:59:25 +0000
From: Daniel Golle <daniel@...rotopia.org>
To: Rob Herring <robh@...nel.org>
Cc: "A. Sverdlin" <alexander.sverdlin@...mens.com>, netdev@...r.kernel.org,
	Hauke Mehrtens <hauke@...ke-m.de>, Andrew Lunn <andrew@...n.ch>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add
 MaxLinear R(G)MII slew rate

On Tue, Jan 13, 2026 at 10:41:28AM -0600, Rob Herring wrote:
> On Wed, Jan 07, 2026 at 10:00:16AM +0100, A. Sverdlin wrote:
> > From: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> > 
> > Add new maxlinear,slew-rate-txc and maxlinear,slew-rate-txd uint32
> > properties. The properties are only applicable for ports in R(G)MII mode
> > and allow for slew rate reduction in comparison to "normal" default
> > configuration with the purpose to reduce radiated emissions.
> > 
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> > ---
> > Changelog:
> > v4:
> > - separate properties for TXD and TXC pads ("maxlinear," prefix re-appears)
> > v3:
> > - use [pinctrl] standard "slew-rate" property as suggested by Rob
> >   https://lore.kernel.org/all/20251219204324.GA3881969-robh@kernel.org/
> > v2:
> > - unchanged
> > 
> >  .../devicetree/bindings/net/dsa/lantiq,gswip.yaml  | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> > index 205b683849a53..747106810cc17 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> > @@ -106,6 +106,20 @@ patternProperties:
> >          unevaluatedProperties: false
> >  
> >          properties:
> > +          maxlinear,slew-rate-txc:
> > +            $ref: /schemas/types.yaml#/definitions/uint32
> > +            enum: [0, 1]
> 
> default: 0

Not really. The default is not to touch the register value which may
have already been setup by the bootloader.

> 
> > +            description: |
> > +              RMII/RGMII TX Clock Slew Rate:
> 
> blank line
> > +              0: "Normal"
> > +              1: "Slow"
> 
> Indent lists by 2 more spaces. Drop the quotes.
> 
> > +          maxlinear,slew-rate-txd:
> > +            $ref: /schemas/types.yaml#/definitions/uint32
> > +            enum: [0, 1]
> > +            description: |
> > +              RMII/RGMII TX Non-Clock PAD Slew Rate:
> > +              0: "Normal"
> > +              1: "Slow"
> >            maxlinear,rmii-refclk-out:
> >              type: boolean
> >              description:
> > -- 
> > 2.52.0
> >