linux-kernel - Re: [PATCH 0/2] nfsd/sunrpc: fix up some layering violations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D867076E-FF23-47C5-87BD-5DE805DF4ED1@hammerspace.com>
Date: Tue, 13 Jan 2026 13:53:18 -0500
From: Benjamin Coddington <bcodding@...merspace.com>
To: Jeff Layton <jlayton@...nel.org>
Cc: Chuck Lever <chuck.lever@...cle.com>, NeilBrown <neil@...wn.name>,
 Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>,
 Tom Talpey <tom@...pey.com>, Trond Myklebust <trondmy@...nel.org>,
 Anna Schumaker <anna@...nel.org>, linux-nfs@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] nfsd/sunrpc: fix up some layering violations

On 13 Jan 2026, at 13:37, Jeff Layton wrote:

> The rq_lease_breaker and rq_cachetype fields are only used by nfsd.
> These patches shrink struct svc_rqst slightly and makes the layering
> between the two a little cleaner. In the case of rq_lease_breaker, I
> think this also gives us a little more type safety.
>
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---
> Jeff Layton (2):
>       nfsd/sunrpc: add svc_rqst->rq_private pointer and remove rq_lease_breaker
>       nfsd/sunrpc: move rq_cachetype into struct nfsd_thread_local_info
>
>  fs/nfsd/nfs4proc.c         | 3 ++-
>  fs/nfsd/nfs4state.c        | 9 ++++++---
>  fs/nfsd/nfs4xdr.c          | 3 ++-
>  fs/nfsd/nfscache.c         | 3 ++-
>  fs/nfsd/nfsd.h             | 5 +++++
>  fs/nfsd/nfssvc.c           | 8 ++++++--
>  include/linux/sunrpc/svc.h | 6 ++++--
>  7 files changed, 27 insertions(+), 10 deletions(-)
> ---
> base-commit: e42954bff52b9538de21267c1bde2567b13b6632
> change-id: 20260113-rq_private-05f22aac0c20
>
> Best regards,
> -- 
> Jeff Layton <jlayton@...nel.org>

Both look good to me:

Reviewed-by: Benjamin Coddington <bcodding@...merspace.com>

Ben