linux-kernel - Re: [PATCH v3 3/4] dt-bindings: can: renesas,rcar-canfd: Document RZ/T2H and RZ/N2H SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUrSUeOFvyX-RhjFV8HfiGtvOvBT-Wd328C4P-j-N0fHw@mail.gmail.com>
Date: Tue, 13 Jan 2026 20:25:47 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Marc Kleine-Budde <mkl@...gutronix.de>, 
	Vincent Mailhol <mailhol@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	linux-can@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v3 3/4] dt-bindings: can: renesas,rcar-canfd: Document
 RZ/T2H and RZ/N2H SoCs

On Mon, 12 Jan 2026 at 18:22, Lad, Prabhakar <prabhakar.csengg@...il.com> wrote:
> On Mon, Jan 12, 2026 at 4:30 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> > On 12/01/2026 15:04, Lad, Prabhakar wrote:
> > >   - if:
> > >       properties:
> > >         compatible:
> > >           contains:
> > >             # SoCs WITH resets but WITHOUT reset-names
> > >             enum:
> > >               - renesas,rcar-gen3-canfd
> > >               - renesas,rcar-gen4-canfd
> > >     then:
> > >       required:
> > >         - resets
> > >       properties:
> > >         reset-names: false
> > >
> >
> > Yes, although now I wonder why do you have such case... There are no
> > benefits in disallowing reset-names, even for single entries.

Except that I have no idea which of the two names I should use in
case of renesas,rcar-gen3-canfd and renesas,rcar-gen4-canfd, as
the hardware documentation doesn't explain that?  AFAIU it is just
a single, common reset for the whole block...

> Ok, I will update the resets property in patch 1/4 as below. Would you
> prefer reset-names as a required property for single resets?
>
>   reset-names:
>     minItems: 1
>     maxItems: 2
>     items:
>       enum:
>         - rstp_n
>         - rstc_n

I.e. which one should I pick?
<grin>Obviously the first, so dtbs_check succeeds?</grin>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds