linux-kernel - Re: [PATCH 1/3] arm64: dts: rockchip: Add modem to the Pinephone Pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ngikrgfwonxbgim2cp3xiqbahgxhsmsaou6lblcbna7wrb6wdr@djb46eqys7tx>
Date: Tue, 13 Jan 2026 21:47:25 +0100
From: Ondřej Jirman <megi@....cz>
To: guptarud@...il.com
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, Lee Jones <lee@...nel.org>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Martijn Braam <martijn@...xit.nl>, Kamil Trzciński <ayufan@...fan.eu>, 
	Danct12 <danct12@...root.org>
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Add modem to the Pinephone Pro

Hello Rudraksha,

On Mon, Jan 12, 2026 at 10:42:24PM -0800, Rudraksha Gupta via B4 Relay wrote:
> From: Rudraksha Gupta <guptarud@...il.com>
> 
> This adds the Quectel EG25-G modem to the Pinephone Pro.
> 
> Co-developed-by: Martijn Braam <martijn@...xit.nl>
> Signed-off-by: Martijn Braam <martijn@...xit.nl>
> Co-developed-by: Kamil Trzciński <ayufan@...fan.eu>
> Signed-off-by: Kamil Trzciński <ayufan@...fan.eu>
> Co-developed-by: Ondrej Jirman <megi@....cz>
> Signed-off-by: Ondrej Jirman <megi@....cz>
> Co-developed-by: Danct12 <danct12@...root.org>
> Signed-off-by: Danct12 <danct12@...root.org>
> Signed-off-by: Rudraksha Gupta <guptarud@...il.com>
> ---
>  .../boot/dts/rockchip/rk3399-pinephone-pro.dts     | 83 ++++++++++++++++++++++
>  1 file changed, 83 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> index 6b35f59cd58e..97d0bf455258 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> @@ -97,6 +97,46 @@ multi-led {
>  		leds = <&led_red>, <&led_green>, <&led_blue>;
>  	};
>  
> +	vcc_4g_5v: regulator-vcc-4g-5v {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpio = <&gpio1 RK_PC7 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vcc_4g_5v_en>;
> +		regulator-name = "vcc_4g_5v";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		vin-supply = <&vcc5v0_sys>;
> +		regulator-always-on;
> +	};
> +
> +	vcc_4g: regulator-vcc-4g {
> +		compatible = "regulator-fixed";
> +		enable-active-high;
> +		gpio = <&gpio4 RK_PC7 GPIO_ACTIVE_HIGH>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vcc_4g_en>;
> +		regulator-name = "vcc_4g";
> +		regulator-min-microvolt = <3800000>;
> +		regulator-max-microvolt = <3800000>;
> +		vin-supply = <&vcc_sys>;
> +		regulator-always-on;
> +	};
> +
> +	vcc5v0_sys: regulator-vcc5v0-host {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc5v0_sys";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		regulator-always-on;
> +		regulator-boot-on;
> +		vin-supply = <&boost_otg>;
> +
> +		regulator-state-mem {
> +			regulator-on-in-suspend;
> +		};

This does nothing for regulator-fixed. And in any case, there's no such
regulator in the schematic. vcc5v0_sys is just alias for boost output from
RK818.

See: https://xff.cz/dl/tmp/0864afaf8d21b1a5.png

So you can remove this completely and just add vcc5v0_sys alias to DCDC_BOOST.

Best regards,
	o.

> +	};
> +
>  	vcc_sys: regulator-vcc-sys {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vcc_sys";
> @@ -274,6 +314,17 @@ rk818: pmic@1c {
>  		vcc9-supply = <&vcc3v3_sys>;
>  
>  		regulators {
> +			boost_otg: DCDC_BOOST {
> +				regulator-name = "boost_otg";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <5000000>;
> +				regulator-max-microvolt = <5000000>;
> +				regulator-state-mem {
> +					regulator-on-in-suspend;
> +				};
> +			};
> +
>  			vdd_cpu_l: DCDC_REG1 {
>  				regulator-name = "vdd_cpu_l";
>  				regulator-always-on;
> @@ -702,6 +753,16 @@ blue_led_pin: blue-led-pin {
>  		};
>  	};
>  
> +	modem {
> +		vcc_4g_5v_en: vcc-4g-5v-en-pin {
> +			rockchip,pins = <1 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +
> +		vcc_4g_en: vcc-4g-en-pin {
> +			rockchip,pins = <4 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +	};
> +
>  	pmic {
>  		pmic_int_l: pmic-int-l {
>  			rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
> @@ -827,6 +888,16 @@ &tsadc {
>  	status = "okay";
>  };
>  
> +
> +&u2phy1 {
> +	status = "okay";
> +};
> +
> +&u2phy1_host {
> +	status = "okay";
> +	phy-supply = <&vcc5v0_sys>;
> +};
> +
>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_xfer &uart0_cts &uart0_rts>;
> @@ -852,6 +923,18 @@ &uart2 {
>  	status = "okay";
>  };
>  
> +&uart3 {
> +	status = "okay";
> +};
> +
> +&usb_host1_ehci {
> +	status = "okay";
> +};
> +
> +&usb_host1_ohci {
> +	status = "okay";
> +};
> +
>  &vopb {
>  	status = "okay";
>  	assigned-clocks = <&cru DCLK_VOP0_DIV>, <&cru DCLK_VOP0>,
> 
> -- 
> 2.52.0
> 
>