linux-kernel - Re: [PATCH v1] perf: Make more global variables static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWa75MJy7FMyzR9P@x1>
Date: Tue, 13 Jan 2026 18:40:52 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Guo Ren <guoren@...nel.org>, Paul Walmsley <pjw@...nel.org>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	Ankur Arora <ankur.a.arora@...cle.com>,
	Howard Chu <howardchu95@...il.com>,
	Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
	"Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
	James Clark <james.clark@...aro.org>, Leo Yan <leo.yan@....com>,
	Yujie Liu <yujie.liu@...el.com>, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf: Make more global variables static

On Fri, Jan 09, 2026 at 05:36:54PM -0800, Namhyung Kim wrote:
> On Thu, Dec 04, 2025 at 01:42:35PM -0800, Ian Rogers wrote:
> > `make check` will run sparse on the perf code base. A frequent warning
> > is "warning: symbol '...' was not declared. Should it be static?" Go
> > through and make global definitions without declarations static. In
> > some cases it is deliberate due to dlsym accessing the symbol, this
> > change doesn't clean up the missing declarations for perf test
> > suites. Sometimes things can opportunistically be made const. Making
> > somethings static exposed unused functions warnings, so restructuring
> > of ifdefs was necessary for that. These changes reduce the size of the
> > perf binary by 3,264 bytes.
> > 
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks, applied to perf-tools-next,

- Arnaldo