linux-kernel - Re: [PATCH v1] perf: Switch printf("...%s", strerror(errno)) to printf("...%m")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWa9qmZL9BrY2UlJ@x1>
Date: Tue, 13 Jan 2026 18:48:26 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Blake Jones <blakejones@...gle.com>,
	Zhongqiu Han <quic_zhonhan@...cinc.com>,
	Chun-Tse Shao <ctshao@...gle.com>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	Stephen Brennan <stephen.s.brennan@...cle.com>,
	Thomas Falcon <thomas.falcon@...el.com>,
	Howard Chu <howardchu95@...il.com>, Yunseong Kim <ysk@...lloc.com>,
	Leo Yan <leo.yan@....com>, Dmitry Vyukov <dvyukov@...gle.com>,
	Haibo Xu <haibo1.xu@...el.com>,
	Alexandre Ghiti <alexghiti@...osinc.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf: Switch printf("...%s", strerror(errno)) to
 printf("...%m")

On Fri, Jan 09, 2026 at 05:25:10PM -0800, Namhyung Kim wrote:
> On Wed, Nov 19, 2025 at 03:36:21PM -0800, Ian Rogers wrote:
> > strerror has thread safety issues, strerror_r requires stack allocated
> > buffers. Code in perf has already been using the "%m" formatting flag
> > that is a widely support glibc extension to print the current errno's
> > description. Expand the usage of this formatting flag and remove usage
> > of strerror/strerror_r.
> > 
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks, applied to perf-tools-next,

- Arnaldo