linux-kernel - Re: [PATCH v3] staging: fbtft: Change udelay() to fsleep()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ved+zhACJ9CYLYnkzW6Z52fmZT0VY+0NWKYk6O38HCkdg@mail.gmail.com>
Date: Wed, 14 Jan 2026 00:33:42 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Gideon Adjei <gideonadjei.dev@...il.com>
Cc: Andy Shevchenko <andy@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Abdun Nihaal <abdun.nihaal@...il.com>, Dan Carpenter <dan.carpenter@...aro.org>, 
	Jianglei Nie <niejianglei2021@....com>, Matthew Wilcox <willy@...radead.org>, 
	dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: fbtft: Change udelay() to fsleep()

On Wed, Jan 14, 2026 at 12:17 AM Gideon Adjei <gideonadjei.dev@...il.com> wrote:
>
> Replace udelay() calls >= 100us with fsleep() to avoid busy-waiting.
>
> The delays are used in init_display() callbacks. These callbacks are
> invoked by fbtft_probe_common() during the driver's probe path. The
> probe path runs in process context which already uses sleeping APIs.
> This makes fsleep() safe to use in these situations.

You forgot to add a changelog...

> Signed-off-by: Gideon Adjei <gideonadjei.dev@...il.com>
> ---

...somewhere here.

No need to send v4 because of this, just reply with the changelogs for
v1->v2 and v2->v3.

Also note, it's assumed that even for such a simple patch the time
between versions is at least 24h.

>  drivers/staging/fbtft/fb_tinylcd.c   | 2 +-
>  drivers/staging/fbtft/fb_upd161704.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

-- 
With Best Regards,
Andy Shevchenko