linux-kernel - Re: [PATCH v2 1/2] x86/virt/tdx: Retrieve TDX module version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2f80e63-302a-47a0-b165-e7abe164a4be@intel.com>
Date: Tue, 13 Jan 2026 11:58:39 +0800
From: Xiaoyao Li <xiaoyao.li@...el.com>
To: Xu Yilun <yilun.xu@...ux.intel.com>, Dave Hansen <dave.hansen@...el.com>
Cc: Vishal Verma <vishal.l.verma@...el.com>, linux-kernel@...r.kernel.org,
 linux-coco@...ts.linux.dev, kvm@...r.kernel.org, x86@...nel.org,
 Chao Gao <chao.gao@...el.com>, Dan Williams <dan.j.williams@...el.com>,
 Kai Huang <kai.huang@...el.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>,
 Kiryl Shutsemau <kas@...nel.org>, Rick Edgecombe <rick.p.edgecombe@...el.com>
Subject: Re: [PATCH v2 1/2] x86/virt/tdx: Retrieve TDX module version

On 1/13/2026 10:56 AM, Xu Yilun wrote:
> On Mon, Jan 12, 2026 at 06:56:58AM -0800, Dave Hansen wrote:
>> On 1/11/26 18:25, Xiaoyao Li wrote:
>>> ... I know it's because minor_version has the least field ID among the
>>> three. But the order of the field IDs doesn't stand for the order of the
>>> reading. Reading the middle part y of x.y.z as first step looks a bit odd.
>>
>> I wouldn't sweat it either way. Reading 4, 3, 5 would also look odd. I'm
>> fine with it as-is in the patch.
> 
> I prefer 3, 4, 5. The field IDs are not human readable hex magic so
> should take extra care when copying from excel file to C file manually,
> A different list order would make the code adding & reviewing even
> harder.

I guess eventually we will introduce MACROs for these magic numbers to 
make the code more readable given that the decision is no longer 
auto-generate the code by the script? Though I'm not sure when that will 
happen.