linux-kernel - Re: [RFC PATCH 01/77] checks: Use consistent type for strspn() returned value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWXNN0bW_xx-YMy1@zatzit>
Date: Tue, 13 Jan 2026 15:42:31 +1100
From: David Gibson <david@...son.dropbear.id.au>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Ayush Singh <ayush@...gleboard.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	devicetree-compiler@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree-spec@...r.kernel.org,
	Hui Pu <hui.pu@...ealthcare.com>,
	Ian Ray <ian.ray@...ealthcare.com>,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [RFC PATCH 01/77] checks: Use consistent type for strspn()
 returned value

On Tue, Jan 13, 2026 at 02:08:54PM +1100, David Gibson wrote:
> On Mon, Jan 12, 2026 at 03:18:51PM +0100, Herve Codina wrote:
> > strspn() returns a size_t value.
> > 
> > The function is called in several places and in all places this value is
> > stored in a size_t variable except in check_node_name_chars_strict().
> > 
> > Fix the variable type used in check_node_name_chars_strict().
> > 
> > Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> 
> This one makes sense regardless of the rest, so, merged.

I spoke too soon.  This causes a compile error:

https://github.com/dgibson/dtc/actions/runs/20944813954/job/60185662154#step:5:130

For some reason it's only showing on the make build, not meson.  I
guess there must be a mismatch in which warnings are enabled.

> 
> > ---
> >  checks.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/checks.c b/checks.c
> > index 5d09216..041e565 100644
> > --- a/checks.c
> > +++ b/checks.c
> > @@ -324,7 +324,7 @@ ERROR(node_name_chars, check_node_name_chars, NODECHARS);
> >  static void check_node_name_chars_strict(struct check *c, struct dt_info *dti,
> >  					 struct node *node)
> >  {
> > -	int n = strspn(node->name, c->data);
> > +	size_t n = strspn(node->name, c->data);
> >  
> >  	if (n < node->basenamelen)
> >  		FAIL(c, dti, node, "Character '%c' not recommended in node name",
> > -- 
> > 2.52.0
> > 
> > 
> 
> -- 
> David Gibson (he or they)	| I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
> 				| around.
> http://www.ozlabs.org/~dgibson



-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)