linux-kernel - Re: [PATCH v3 05/10] riscv: conditionally compile GHES NMI spool function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB19ukF+3tBG=nXe8is5_3xWkt7avjAQ2o5cS=44SAf0mkVPwA@mail.gmail.com>
Date: Tue, 13 Jan 2026 10:43:14 +0530
From: Sunil V L <sunilvl@....qualcomm.com>
To: Himanshu Chauhan <himanshu.chauhan@....qualcomm.com>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-efi@...r.kernel.org,
        acpica-devel@...ts.linux.dev, paul.walmsley@...ive.com,
        palmer@...belt.com, lenb@...nel.org, james.morse@....com,
        tony.luck@...el.com, ardb@...nel.org, conor@...nel.org,
        cleger@...osinc.com, robert.moore@...el.com,
        anup.patel@....qualcomm.com
Subject: Re: [PATCH v3 05/10] riscv: conditionally compile GHES NMI spool function

On Fri, Jan 9, 2026 at 2:32 PM Himanshu Chauhan
<himanshu.chauhan@....qualcomm.com> wrote:
>
> Compile ghes_in_nmi_spool_from_list only when NMI and SEA
> is enabled. Otherwise compilation fails with "defined but
> not used" error.
>
> Signed-off-by: Himanshu Chauhan <himanshu.chauhan@....qualcomm.com>
> ---
>  drivers/acpi/apei/ghes.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 0dc767392a6c..6fd84a1772c6 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1387,6 +1387,7 @@ static int ghes_in_nmi_queue_one_entry(struct ghes *ghes,
>         return rc;
>  }
>
> +#if defined(CONFIG_HAVE_ACPI_APEI_NMI) || defined(CONFIG_ACPI_APEI_SEA)
>  static int ghes_in_nmi_spool_from_list(struct list_head *rcu_list,
>                                        enum fixed_addresses fixmap_idx)
>  {
> @@ -1405,6 +1406,7 @@ static int ghes_in_nmi_spool_from_list(struct list_head *rcu_list,
>
>         return ret;
>  }
> +#endif
>
LGTM.

Reviewed-by: Sunil V L <sunilvl@....qualcomm.com>