linux-kernel - Re: [PATCH 09/27] clk: loongson1: convert from divider_round_rate() to divider_determine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJhJPsXG_UKnVk7RypkKuM8M87+1DNvJND1PRxoPVzAm=P2Rbg@mail.gmail.com>
Date: Tue, 13 Jan 2026 14:28:17 +0800
From: Keguang Zhang <keguang.zhang@...il.com>
To: Brian Masney <bmasney@...hat.com>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH 09/27] clk: loongson1: convert from divider_round_rate()
 to divider_determine_rate()

Reviewed-by: Keguang Zhang <keguang.zhang@...il.com>
Tested-by: Keguang Zhang <keguang.zhang@...il.com> # on LS1B & LS1C

On Fri, Jan 9, 2026 at 5:17 AM Brian Masney <bmasney@...hat.com> wrote:
>
> The divider_round_rate() function is now deprecated, so let's migrate
> to divider_determine_rate() instead so that this deprecated API can be
> removed.
>
> Note that when the main function itself was migrated to use
> determine_rate, this was mistakenly converted to:
>
>     req->rate = divider_round_rate(...)
>
> This is invalid in the case when an error occurs since it can set the
> rate to a negative value.
>
> Fixes: bb40a2ef4fc9 ("clk: loongson1: convert from round_rate() to determine_rate()")
> Signed-off-by: Brian Masney <bmasney@...hat.com>
>
> ---
> To: Keguang Zhang <keguang.zhang@...il.com>
> Cc: linux-mips@...r.kernel.org
> ---
>  drivers/clk/clk-loongson1.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/clk/clk-loongson1.c b/drivers/clk/clk-loongson1.c
> index f9f060d08a5fae3291a9408c6dc93531b435609f..1674181a1107dc4f30e78ee410a55a49b6d0b4b5 100644
> --- a/drivers/clk/clk-loongson1.c
> +++ b/drivers/clk/clk-loongson1.c
> @@ -99,10 +99,7 @@ static int ls1x_divider_determine_rate(struct clk_hw *hw,
>         struct ls1x_clk *ls1x_clk = to_ls1x_clk(hw);
>         const struct ls1x_clk_div_data *d = ls1x_clk->data;
>
> -       req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
> -                                      d->table, d->width, d->flags);
> -
> -       return 0;
> +       return divider_determine_rate(hw, req, d->table, d->width, d->flags);
>  }
>
>  static int ls1x_divider_set_rate(struct clk_hw *hw, unsigned long rate,
>
> --
> 2.52.0
>


-- 
Best regards,

Keguang Zhang