linux-kernel - Re: [PATCH v2 10/13] exfat: support multi-cluster for exfat_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PUZPR04MB631615D6191EF6FB711E63C3818EA@PUZPR04MB6316.apcprd04.prod.outlook.com>
Date: Tue, 13 Jan 2026 06:37:44 +0000
From: "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>
To: Chi Zhiling <chizhiling@....com>,
        "linux-fsdevel@...r.kernel.org"
	<linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Namjae Jeon <linkinjeon@...nel.org>,
        Sungjong Seo
	<sj1557.seo@...sung.com>,
        Chi Zhiling <chizhiling@...inos.cn>
Subject: Re: [PATCH v2 10/13] exfat: support multi-cluster for
 exfat_map_cluster

> @@ -281,7 +285,7 @@ static int exfat_get_block(struct inode *inode, sector_t iblock,
>        sec_offset = iblock & (sbi->sect_per_clus - 1);
>
>        phys = exfat_cluster_to_sector(sbi, cluster) + sec_offset;
> -       mapped_blocks = sbi->sect_per_clus - sec_offset;
> +       mapped_blocks = (count << sbi->sect_per_clus_bits) - sec_offset;

This left shift will cause an overflow if the file is larger than 2TB 
and the clusters are contiguous.

The others look good.
Reviewed-by: Yuezhang Mo <Yuezhang.Mo@...y.com>