linux-kernel - Re: [PATCH] usb: dwc3: apple: Ignore USB role switches to the active role

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <675f32d7-c866-4b66-93bb-0dc6ed53f5f9@kernel.org>
Date: Tue, 13 Jan 2026 07:58:56 +0100
From: Sven Peter <sven@...nel.org>
To: Janne Grunau <j@...nau.net>, Neal Gompa <neal@...pa.dev>,
 Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH] usb: dwc3: apple: Ignore USB role switches to the active
 role

On 09.01.26 11:13, Janne Grunau wrote:
> Ignore USB role switches if dwc3-apple is already in the desired state.
> The USB-C port controller on M2 and M1/M2 Pro/Max/Ultra devices issues
> additional interrupts which result in USB role switches to the already
> active role.
> Ignore these USB role switches to ensure the USB-C port controller and
> dwc3-apple are always in a consistent state. This matches the behaviour
> in __dwc3_set_mode() in core.c.
> Fixes detecting USB 2.0 and 3.x devices on the affected systems. The
> reset caused by the additional role switch appears to leave the USB
> devices in a state which prevents detection when the phy and dwc3 is
> brought back up again.
> 
> Fixes: 0ec946d32ef7 ("usb: dwc3: Add Apple Silicon DWC3 glue layer driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Janne Grunau <j@...nau.net>
> ---

Reviewed-by: Sven Peter <sven@...nel.org>
Tested-by: Sven Peter <sven@...nel.org> # M1 mac mini and macbook air


thanks,


Sven