linux-kernel - Re: [PATCH V4 2/4] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b50dc9ce-7fb1-46dd-8adf-e58778553934@oss.qualcomm.com>
Date: Tue, 13 Jan 2026 12:55:13 +0530
From: Ram Kumar Dwivedi <ram.dwivedi@....qualcomm.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: mani@...nel.org, alim.akhtar@...sung.com, avri.altman@....com,
        bvanassche@....org, robh@...nel.org, krzk+dt@...nel.org,
        conor+dt@...nel.org, James.Bottomley@...senpartnership.com,
        martin.petersen@...cle.com, linux-arm-msm@...r.kernel.org,
        linux-scsi@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Anjana Hari <anjana.hari@....qualcomm.com>
Subject: Re: [PATCH V4 2/4] dt-bindings: ufs: Document bindings for SA8255P
 UFS Host Controller



On 07-Jan-26 1:08 PM, Krzysztof Kozlowski wrote:
> On Tue, Jan 06, 2026 at 07:10:06PM +0530, Ram Kumar Dwivedi wrote:
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> +        ufshc@...4000 {
> 
> Completely messed indentation.
> 
> Why did we ask to drop the unnecessary soc node? To make it simpler.
> 
> Even if you do not believe that code should be simpler, you should
> immediately spot the odd indentation.
> 
> For such trivialities you cannot get this patch merged. It's third
> revision which you send carelessly.

Hi Krzysztof,

Apologies for the oversight. I missed correcting the indentation after removing the 'soc' node wrapper.
I will ensure the example is correctly indented in the next version.

Thanks,
Ram


> 
> Best regards,
> Krzysztof
>