linux-kernel - Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6777df67-e6db-4f11-a971-9627fe86765e@kernel.org>
Date: Tue, 13 Jan 2026 08:29:10 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jeff Johnson <jeff.johnson@....qualcomm.com>,
 Miaoqing Pan <miaoqing.pan@....qualcomm.com>, jjohnson@...nel.org,
 johannes@...solutions.net, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org
Cc: ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH ath-current 2/2] dt-bindings: net: wireless: ath11k-pci:
 deprecate 'firmware-name' property

On 12/01/2026 20:51, Jeff Johnson wrote:
> On 12/11/2025 7:23 PM, Krzysztof Kozlowski wrote:
>> On 11/12/2025 17:44, Jeff Johnson wrote:
>>> On 12/3/2025 11:11 PM, Miaoqing Pan wrote:
>>>> The firmware-name property was introduced to allow end-users and
>>>> integrators to select usecase specific firmware for the WCN6855.
>>>> However, specifying firmware for an M.2 WLAN module in the Device
>>>> Tree is not appropriate. Instead, this functionality will be handled
>>>> within the ath11k driver.
>>>>
>>>> Signed-off-by: Miaoqing Pan <miaoqing.pan@....qualcomm.com>
>>>> ---
>>>>  .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml        | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>>> index e34d42a30192..0162e365798b 100644
>>>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>>>> @@ -37,6 +37,7 @@ properties:
>>>>  
>>>>    firmware-name:
>>>>      maxItems: 1
>>>> +    deprecated: true
>>>>      description:
>>>>        If present, a board or platform specific string used to lookup
>>>>        usecase-specific firmware files for the device.
>>>
>>> The driver patch completely removes support for this, so is this really
>>> considered deprecated? Or should this actually be considered obsolete and
>>
>> That's silent ABI break. I will formally NAK the patch.
>>
>>
>>> completely removed?
>>>
>>> Do any DTS files actually reference this?
>>>
>>> /jeff
>>
>>
>> Best regards,
>> Krzysztof
> 
> Krzysztof,
> Can you check the v2 to see if you still want to NAK?
> 
> https://msgid.link/20251214025230.716387-3-miaoqing.pan@oss.qualcomm.com
> 

First, yes, still NAK.

Second, that patch faked Rob's tag, so it is unacceptable!

Best regards,
Krzysztof