linux-kernel - Re: [PATCH] scsi: ufs: core: Handle sentinel value for dHIDAvailableSize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aee15d0084e1801378ec8f8296bc04c58416d916.camel@mediatek.com>
Date: Tue, 13 Jan 2026 07:24:17 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "avri.altman@....com" <avri.altman@....com>, "liu.song13@....com.cn"
	<liu.song13@....com.cn>, "tanghuan@...o.com" <tanghuan@...o.com>,
	"quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>,
	"zhongqiu.han@....qualcomm.com" <zhongqiu.han@....qualcomm.com>,
	"bvanassche@....org" <bvanassche@....org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "keosung.park@...sung.com"
	<keosung.park@...sung.com>, "chullee@...gle.com" <chullee@...gle.com>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: core: Handle sentinel value for
 dHIDAvailableSize

On Fri, 2025-12-26 at 13:28 +0900, Keoseong Park wrote:
> JEDEC UFS spec defines 0xFFFFFFFF for dHIDAvailableSize as indicating
> no
> valid fragmented size information. Returning the raw value can
> mislead
> userspace. Return -ENODATA instead when the value is unavailable.
> 
> Signed-off-by: Keoseong Park <keosung.park@...sung.com>
> ---
>  drivers/ufs/core/ufs-sysfs.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ufs/core/ufs-sysfs.c b/drivers/ufs/core/ufs-
> sysfs.c
> index b33f8656edb5..1017dd3ae5d3 100644
> --- a/drivers/ufs/core/ufs-sysfs.c
> +++ b/drivers/ufs/core/ufs-sysfs.c
> @@ -1847,6 +1847,7 @@ static ssize_t defrag_trigger_store(struct
> device *dev,
> 
>  static DEVICE_ATTR_WO(defrag_trigger);
> 
> +#define UFS_HID_AVAILABLE_SIZE_INVALID 0xFFFFFFFFU
>  static ssize_t fragmented_size_show(struct device *dev,
>                 struct device_attribute *attr, char *buf)
>  {
> @@ -1859,6 +1860,9 @@ static ssize_t fragmented_size_show(struct
> device *dev,
>         if (ret)
>                 return ret;
> 
> +       if (value == UFS_HID_AVAILABLE_SIZE_INVALID)
> +               return -ENODATA;
> +
>         return sysfs_emit(buf, "%u\n", value);
>  }

Reviewed-by: Peter Wang <peter.wang@...iatek.com>