linux-kernel - Re: [v2 PATCH] crypto: seqiv - Do not use req->iv after crypto_aead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWX8qNm9iwYFyoxO@gondor.apana.org.au>
Date: Tue, 13 Jan 2026 16:04:56 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Xin Long <lucien.xin@...il.com>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S . Miller" <davem@...emloft.net>,
	Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [v2 PATCH] crypto: seqiv - Do not use req->iv after
 crypto_aead_encrypt

On Wed, Dec 31, 2025 at 04:06:48PM -0500, Xin Long wrote:
>
> BTW, Do you think it might have the similar issue in essiv_aead_crypt()?
> 
>         if (rctx->assoc && err != -EINPROGRESS && err != -EBUSY)
>                 kfree(rctx->assoc);

We should fix this, but I believe this dereference (after free) is
harmless.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt