[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260112194551.2446d041@gandalf.local.home>
Date: Mon, 12 Jan 2026 19:45:51 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] tracing: Make the backup instance readonly
On Tue, 13 Jan 2026 09:31:00 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:
> > + static struct eventfs_entry event_ro_entries[] = {
> > + {
> > + .name = "format",
> > + .callback = event_callback,
> > + },
> > +#ifdef CONFIG_PERF_EVENTS
> > + {
> > + .name = "id",
> > + .callback = event_callback,
> > + },
> > +#endif
> > + };
>
> Thinking about this hack again, it would be easier to maintain if I add
> a readonly flag to each eventfs_entry and specify readonly when creating
> the eventfs top directory.
>
> Let me update it.
Let's not add any flags to the eventfs_entry. That is created for every
event, and events are already too big in size. I don't want to increase the
size of each event for this feature.
-- Steve
Powered by blists - more mailing lists