linux-kernel - Re: [PATCH v2 3/7] irqdomain: Add parent field to struct irqchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sec9etv3.ffs@tglx>
Date: Tue, 13 Jan 2026 10:37:20 +0100
From: Thomas Gleixner <tglx@...nel.org>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>, Jonathan Cameron
 <jonathan.cameron@...wei.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
 Robert Moore <robert.moore@...el.com>, Hanjun Guo <guohanjun@...wei.com>,
 Sudeep Holla <sudeep.holla@....com>, Marc Zyngier <maz@...nel.org>, Bjorn
 Helgaas <bhelgaas@...gle.com>, linux-acpi@...r.kernel.org,
 acpica-devel@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v2 3/7] irqdomain: Add parent field to struct irqchip_fwid

On Wed, Jan 07 2026 at 18:31, Lorenzo Pieralisi wrote:
> On Wed, Jan 07, 2026 at 10:04:52AM +0000, Jonathan Cameron wrote:
>> Agreed. Let's see what Thomas prefers (i.e. make the decision his problem ;)
>
> Thomas do you have any preference on the matter please ? It is not a big deal
> either way I'd just like to respin promptly (provided the rest of the series
> does not require further changes other than the ones Jon suggested and I
> addressed) if possible please.

Hiding the NULL parameters in helpers is perfectly fine. I agree with
Jonathan to make the name of the new helper more intuitive, but other
than that this looks sane.

Thanks,

        tglx