linux-kernel - Re: [PATCH v2 1/5] dt-bindings: clock: google,gs101-clock: fix alphanumeric ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1045dd2f33ed3a618381448717b0b5d5b28dcb5.camel@linaro.org>
Date: Tue, 13 Jan 2026 09:58:38 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Peter Griffin <peter.griffin@...aro.org>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>, Michael Turquette	
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring	
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley	
 <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>, Sylwester
 Nawrocki <s.nawrocki@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>, 
	linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org, 
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk@...nel.org>, 
	kernel-team@...roid.com, Will McVicker <willmcvicker@...gle.com>, Juan
 Yescas	 <jyescas@...gle.com>, Doug Anderson <dianders@...gle.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: clock: google,gs101-clock: fix
 alphanumeric ordering

Hi Peter,

On Tue, 2026-01-13 at 09:13 +0000, Peter Griffin wrote:
> Hi André,
> 
> On Mon, 12 Jan 2026 at 14:26, André Draszik <andre.draszik@...aro.org> wrote:
> > 
> > On Mon, 2026-01-12 at 14:16 +0000, Peter Griffin wrote:
> > > Fix the places that don't have correct alphanumeric ordering. This will
> > > make reasoning about where to add future entries more straightforward.
> > > 
> > > Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> > > ---
> > >  Documentation/devicetree/bindings/clock/google,gs101-clock.yaml | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> > > b/Documentation/devicetree/bindings/clock/google,gs101-
> > > clock.yaml
> > > index 09e679c1a9def03d53b8b493929911ea902a1763..a8176687bb773ae90800b9c256bcccebfdef2e49 100644
> > > --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> > > @@ -27,13 +27,13 @@ description: |
> > >  properties:
> > >    compatible:
> > >      enum:
> > > -      - google,gs101-cmu-top
> > >        - google,gs101-cmu-apm
> > > -      - google,gs101-cmu-misc
> > >        - google,gs101-cmu-hsi0
> > >        - google,gs101-cmu-hsi2
> > > +      - google,gs101-cmu-misc
> > >        - google,gs101-cmu-peric0
> > >        - google,gs101-cmu-peric1
> > > +      - google,gs101-cmu-top
> > 
> > If we keep 'top' at the top as one outlier, it'd reflect that it is the
> > top unit and all other CMUs are children of it.
> 
> Thanks for the review. I opted to just keep it alphanumeric so it's
> (hopefully) obvious what all future ordering should be.

One last comment: except that all other source files in the tree place
cmu_top at the top. It'd be more consistent with those files if done
similarly here.

Cheers,
Andre