[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aWYVg6_i6rvTTHxo@jlelli-thinkpadt14gen4.remote.csb>
Date: Tue, 13 Jan 2026 10:50:59 +0100
From: Juri Lelli <juri.lelli@...hat.com>
To: Gabriele Monaco <gmonaco@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
linux-kernel@...r.kernel.org, williams@...hat.com
Subject: Re: [PATCH] sched/deadline: Fix server stopping with runnable tasks
On 13/01/26 10:42, Gabriele Monaco wrote:
> On Tue, 2026-01-13 at 10:37 +0100, Peter Zijlstra wrote:
> > > static void update_curr_dl_se(struct rq *rq, struct sched_dl_entity *dl_se,
> > > s64 delta_exec)
> > > {
> > > - bool idle = rq->curr == rq->idle;
> > > + bool idle = rq->curr == rq->idle && !rq->nr_running && !rq-
> > > >ttwu_pending;
> >
> > This is idle_cpu(), perhaps we can lift that thing into sched.h or so.
> >
>
> Yeah, that's what I meant by quick and dirty.. I have idle_cpu() on the model
> side (and have them matching simplifies a lot of things).
>
> I just wasn't sure if we wanted a function call in there. But we can probably do
> something nicer without it too.
Thanks for the patch (looks sensible to me too) and nice catch from the
model!
Powered by blists - more mailing lists