linux-kernel - Re: [PATCH 2/6] i2c: piix4: use i2c_adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWYdST90bR1jpeyx@ninjato>
Date: Tue, 13 Jan 2026 11:24:09 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Jean Delvare <jdelvare@...e.de>
Cc: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>,
	Andi Shyti <andi.shyti@...nel.org>,
	Shyam Sundar S K <shyam-sundar.s-k@....com>,
	Nirujogi Pratap <pratap.nirujogi@....com>, Bin Du <bin.du@....com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>,
	Gregory CLEMENT <gregory.clement@...tlin.com>,
	Hans Hu <hanshu@...oxin.com>, Bartosz Golaszewski <brgl@...nel.org>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] i2c: piix4: use i2c_adapter_dev()

Hi Jean,

> > Use i2c_adapter_dev() where applicable in order to avoid direct
> > dereferencing of struct device embedded within struct i2c_adapter.
> 
> I will confess that I don't know what is wrong with the current way of
> embedding struct device in a more specific device structure. I seem to
> recall it was fairly standard to do things this way back when we
> implemented this in the i2c subsystem. But I will trust you that this
> change is needed now.

I guess more people will wonder about the upcoming I2C core changes, so
I wrote a bit of explanation:

https://lore.kernel.org/all/aWYYZEPX-_1GfQtL@ninjato/

Happy hacking,

   Wolfram