linux-kernel - Re: [PATCH v6 4/5] PCI: dwc: ep: Support BAR subrange inbound mapping via Address Match Mode iATU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWYeHNoPEl9T-Qo-@ryzen>
Date: Tue, 13 Jan 2026 11:27:40 +0100
From: Niklas Cassel <cassel@...nel.org>
To: Koichiro Den <den@...inux.co.jp>
Cc: jingoohan1@...il.com, mani@...nel.org, lpieralisi@...nel.org,
	kwilczynski@...nel.org, robh@...nel.org, bhelgaas@...gle.com,
	vigneshr@...com, s-vadapalli@...com, hongxing.zhu@....com,
	l.stach@...gutronix.de, shawnguo@...nel.org, s.hauer@...gutronix.de,
	kernel@...gutronix.de, festevam@...il.com, minghuan.Lian@....com,
	mingkai.hu@....com, roy.zang@....com, jesper.nilsson@...s.com,
	heiko@...ech.de, srikanth.thokala@...el.com,
	marek.vasut+renesas@...il.com, yoshihiro.shimoda.uh@...esas.com,
	geert+renesas@...der.be, magnus.damm@...il.com,
	christian.bruel@...s.st.com, mcoquelin.stm32@...il.com,
	alexandre.torgue@...s.st.com, thierry.reding@...il.com,
	jonathanh@...dia.com, hayashi.kunihiko@...ionext.com,
	mhiramat@...nel.org, kishon@...nel.org, jirislaby@...nel.org,
	rongqianfeng@...o.com, 18255117159@....com,
	shawn.lin@...k-chips.com, nicolas.frattaroli@...labora.com,
	linux.amoon@...il.com, vidyas@...dia.com, Frank.Li@....com,
	linux-omap@...r.kernel.org, linux-pci@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev, linuxppc-dev@...ts.ozlabs.org,
	linux-arm-kernel@...s.com, linux-rockchip@...ts.infradead.org,
	linux-arm-msm@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-tegra@...r.kernel.org
Subject: Re: [PATCH v6 4/5] PCI: dwc: ep: Support BAR subrange inbound
 mapping via Address Match Mode iATU

On Tue, Jan 13, 2026 at 11:15:42AM +0100, Niklas Cassel wrote:
> On Tue, Jan 13, 2026 at 11:37:14AM +0900, Koichiro Den wrote:
> > @@ -626,11 +831,22 @@ static const struct pci_epc_features*
> >  dw_pcie_ep_get_features(struct pci_epc *epc, u8 func_no, u8 vfunc_no)
> >  {
> >  	struct dw_pcie_ep *ep = epc_get_drvdata(epc);
> > +	struct pci_epc_features *features;
> >  
> >  	if (!ep->ops->get_features)
> >  		return NULL;
> >  
> > -	return ep->ops->get_features(ep);
> > +	features = ep->ops->get_features(ep);
> > +	if (!features)
> > +		return NULL;
> > +
> > +	/* All DWC-based glue drivers support dynamic inbound mapping */
> > +	features->dynamic_inbound_mapping = true;
> 
> I think you should create a separate patch, before this patch, that simply
> sets:
> features->dynamic_inbound_mapping = true;
> 
> Since that is technically a different feature, independent of this
> feature, so it deserves its own patch.

The commit message for that separate patch should mention that the reason
why there are no code changes when exposing/enabling support for the
dynamic_inbound_mapping feature, is because the actual code changes to the
the DWC driver already in commit 4284c88fff0e ("PCI: designware-ep: Allow
pci_epc_set_bar() update inbound map address").


Kind regards,
Niklas