linux-kernel - Re: [PATCH] arm64: dts: ti: k3-*: Replace rgmii-rxid with rgmii-id for CPSW ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25c59291bdf9dbdf01d5225e20062b19f4852b28.camel@ti.com>
Date: Tue, 13 Jan 2026 16:10:27 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Tom Rini <trini@...sulko.com>, Francesco Dolcini <francesco@...cini.it>
CC: <u-boot@...ts.denx.de>, <nm@...com>, <vigneshr@...com>,
	<kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<srk@...com>, <s-vadapalli@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-*: Replace rgmii-rxid with rgmii-id
 for CPSW ports

On Mon, 2026-01-12 at 12:06 -0600, Tom Rini wrote:
> On Mon, Jan 12, 2026 at 08:56:36AM +0100, Francesco Dolcini wrote:
> > On Mon, Jan 12, 2026 at 08:49:56AM +0100, Francesco Dolcini wrote:
> > > +Tom +U-Boot ML
> > > 
> > > Hello Siddharth,
> > > 
> > > On Sat, Oct 25, 2025 at 01:07:59PM +0530, Siddharth Vadapalli wrote:
> > > > The MAC Ports across all of the CPSW instances (CPSW2G, CPSW3G, CPSW5G and
> > > > CPSW9G) present in various K3 SoCs only support the 'RGMII-ID' mode. This
> > > > correction has been implemented/enforced by the updates to:
> > > > a) Device-Tree binding for CPSW [0]
> > > > b) Driver for CPSW [1]
> > > > c) Driver for CPSW MAC Port's GMII [2]
> > > > 
> > > > To complete the transition from 'RGMII-RXID' to 'RGMII-ID', update the
> > > > 'phy-mode' property for all CPSW ports by replacing 'rgmii-rxid' with
> > > > 'rgmii-id'.
> > > > 
> > > > [0]: commit 9b357ea52523 ("dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example")
> > > > [1]: commit ca13b249f291 ("net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay")
> > > > [2]: commit a22d3b0d49d4 ("phy: ti: gmii-sel: Always write the RGMII ID setting")
> > > 
> > > What about U-Boot?
> > > I just noticed this in today U-Boot master:
> > > 
> > >   RGMII mode without internal TX delay unsupported; please fix your Device Tree
> > > 
> > > and I think this is coming from the DTS update from Linux to U-Boot.
> > > 
> > > Can you look into that?
> > 
> > Ok, I think that the issue is that the U-Boot code was updated
> > correctly, but now we need the v6.19 DT in U-Boot, and as of now we have
> > 6.18 DT.
> > 
> > Tom: are you planning to sync the U-Boot DT to Linux v6.19 before the next
> > U-Boot release?
> 
> Once it's out, yes. But, uh, this tells me some TI folks forgot to
> backport all of the dts changes too then as we shouldn't have broken
> platforms in-tree like this.

In both Linux and U-Boot, the error (warning) message:
    RGMII mode without internal TX delay unsupported; please fix your
Device Tree
only indicates that the device-tree should be updated to use 'rgmii-id'
instead of 'rgmii-rxid'. The functionality however remains unaffected. The
current Linux device-tree patch is not really fixing an issue from a
functionality perspective, and the same holds true for U-Boot.

I realize however that a DT sync patch could (should) have been posted by
me to the U-Boot mailing list after this patch had been merged to Linux
instead of waiting for the periodic DT sync.

Regards,
Siddharth.