linux-kernel - Re: [PATCH 2/2] ASoC: fsl_sai: Add support for i.MX952 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e86fc06-b162-4591-bc8c-e4b2fd487855@gocontroll.com>
Date: Wed, 14 Jan 2026 12:03:00 +0100
From: Maud Spierings <maudspierings@...ontroll.com>
To: shengjiu.wang@....com
Cc: Xiubo.Lee@...il.com, broonie@...nel.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, festevam@...il.com, krzk+dt@...nel.org,
 lgirdwood@...il.com, linux-kernel@...r.kernel.org,
 linux-sound@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 nicoleotsuka@...il.com, perex@...ex.cz, robh@...nel.org,
 shengjiu.wang@...il.com, tiwai@...e.com
Subject: Re: [PATCH 2/2] ASoC: fsl_sai: Add support for i.MX952 platform

> 
> Add compatible string and specific soc data to support SAI on i.MX952
> platform.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> ---
>  sound/soc/fsl/fsl_sai.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 2fa14fbdfe1a..c025041dc079 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -1765,6 +1765,18 @@ static const struct fsl_sai_soc_data fsl_sai_imx95_data = {
>  	.max_burst = {8, 8},
>  };
>  
> +static const struct fsl_sai_soc_data fsl_sai_imx952_data = {
> +	.use_imx_pcm = true,
> +	.use_edma = true,
> +	.fifo_depth = 128,
> +	.reg_offset = 8,
> +	.mclk0_is_mclk1 = false,
> +	.pins = 8,
> +	.flags = 0,
> +	.max_register = FSL_SAI_MCTL,
> +	.max_burst = {8, 8},
> +};
> +
>  static const struct of_device_id fsl_sai_ids[] = {
>  	{ .compatible = "fsl,vf610-sai", .data = &fsl_sai_vf610_data },
>  	{ .compatible = "fsl,imx6sx-sai", .data = &fsl_sai_imx6sx_data },
> @@ -1778,6 +1790,7 @@ static const struct of_device_id fsl_sai_ids[] = {
>  	{ .compatible = "fsl,imx8mn-sai", .data = &fsl_sai_imx8mn_data },
>  	{ .compatible = "fsl,imx93-sai", .data = &fsl_sai_imx93_data },
>  	{ .compatible = "fsl,imx95-sai", .data = &fsl_sai_imx95_data },
> +	{ .compatible = "fsl,imx952-sai", .data = &fsl_sai_imx952_data },
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, fsl_sai_ids);
> -- 
> 2.34.1

scratch my comment on patch 1, drop this patch. the new data struct is 
the exact same as the imx95 one.

Keep the fallback compatible and let it match against that instead of 
introducing a new one in the driver.

Kind regards,
Maud