linux-kernel - Re: [PATCH mm-new v4 2/6] mm: khugepaged: refine scan progress number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301b853-992d-4299-9cc3-32edbf2f078f@kernel.org>
Date: Wed, 14 Jan 2026 12:28:50 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Vernon Yang <vernon2gm@...il.com>, akpm@...ux-foundation.org
Cc: lorenzo.stoakes@...cle.com, ziy@...dia.com, dev.jain@....com,
 baohua@...nel.org, lance.yang@...ux.dev, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Vernon Yang <yanglincheng@...inos.cn>
Subject: Re: [PATCH mm-new v4 2/6] mm: khugepaged: refine scan progress number

On 1/14/26 12:23, David Hildenbrand (Red Hat) wrote:
> 
>>    			mmap_locked = false;
>>    			result = hpage_collapse_scan_file(mm, addr, file, pgoff,
>> -							  cc);
>> +							  NULL, cc);
>>    			fput(file);
>>    		} else {
>>    			result = hpage_collapse_scan_pmd(mm, vma, addr,
>> -							 &mmap_locked, cc);
>> +							 &mmap_locked, NULL, cc);
>>    		}
>>    		if (!mmap_locked)
>>    			*lock_dropped = true;
> 
> Seeing the "NULL" tells me that this patch does effectively nothing and
> should likely get squashed into #3 ?

Ah, sorry, I missed the other instanced where you pass something.

 From another glimpse, LGTM (although I think the end result might look 
better when both patches are squashed; anyhow, patch #3 fixes these 
instances up)

Acked-by: David Hildenbrand (Red Hat) <david@...nel.org>

-- 
Cheers

David