lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2026011400-monthly-commend-f89b@gregkh>
Date: Wed, 14 Jan 2026 12:40:02 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Prashanth K <prashanth.k@....qualcomm.com>
Cc: Thinh Nguyen <Thinh.Nguyen@...opsys.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] usb: dwc3: Log dwc3 address in traces

On Wed, Jan 14, 2026 at 03:37:48PM +0530, Prashanth K wrote:
> + * @address: Cached lower 32-bit base address to be used for logging.

Why are 32bits enough / ok?  Why not use the full 64 that you really
have?  What happens if you have 2 devices with just the upper 32 bits
different?

This is a resource value, so why not use the proper type for it?

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ