linux-kernel - Re: [PATCH 4/5] accel/thames: Add IOCTL for job submission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1acdffd8f05eae0a3531d43d3919d8bd4558f37a@intel.com>
Date: Wed, 14 Jan 2026 14:04:44 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Tomeu Vizoso <tomeu@...euvizoso.net>, Nishanth Menon <nm@...com>,
 "Andrew F. Davis" <afd@...com>, Randolph Sapp <rs@...com>, Jonathan
 Humphreys <j-humphreys@...com>, Andrei Aldea <a-aldea@...com>, Chirag
 Shilwant <c-shilwant@...com>, Vignesh Raghavendra <vigneshr@...com>, Tero
 Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Oded
 Gabbay <ogabbay@...nel.org>, Jonathan Corbet <corbet@....net>, Sumit
 Semwal <sumit.semwal@...aro.org>, Christian König
 <christian.koenig@....com>
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-doc@...r.kernel.org, linux-media@...r.kernel.org,
 linaro-mm-sig@...ts.linaro.org, Tomeu Vizoso <tomeu@...euvizoso.net>
Subject: Re: [PATCH 4/5] accel/thames: Add IOCTL for job submission

On Tue, 13 Jan 2026, Tomeu Vizoso <tomeu@...euvizoso.net> wrote:
> +#include "linux/dev_printk.h"

Random drive-by comment, please use <> instead of "" for include/
headers.

> +#include <drm/drm_file.h>
> +#include <drm/drm_gem.h>
> +#include <drm/drm_print.h>
> +#include <drm/thames_accel.h>
> +#include <linux/platform_device.h>

In general, I think it will make everyone's life easier in the long run
if the include directives are grouped and sorted.

BR,
Jani.

-- 
Jani Nikula, Intel