| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aWeH5fn8nGOzjDpP@vaman>
Date: Wed, 14 Jan 2026 17:41:17 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Yulin Lu <luyulin@...incomputing.com>
Cc: neil.armstrong@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, p.zabel@...gutronix.de,
linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, ningyu@...incomputing.com,
zhengyu@...incomputing.com, linmin@...incomputing.com,
huangyifeng@...incomputing.com, fenglin@...incomputing.com,
lianghujun@...incomputing.com
Subject: Re: [PATCH v7 2/2] phy: eswin: Create eswin directory and add
EIC7700 SATA PHY driver
On 06-01-26, 14:33, Yulin Lu wrote:
> Created the eswin phy driver directory and added support for
> the SATA phy driver on the EIC7700 SoC platform.
>
> Signed-off-by: Yulin Lu <luyulin@...incomputing.com>
> ---
> drivers/phy/Kconfig | 1 +
> drivers/phy/Makefile | 1 +
> drivers/phy/eswin/Kconfig | 14 ++
> drivers/phy/eswin/Makefile | 2 +
> drivers/phy/eswin/phy-eic7700-sata.c | 221 +++++++++++++++++++++++++++
> 5 files changed, 239 insertions(+)
> create mode 100644 drivers/phy/eswin/Kconfig
> create mode 100644 drivers/phy/eswin/Makefile
> create mode 100644 drivers/phy/eswin/phy-eic7700-sata.c
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 678dd0452f0a..6d50704917f0 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -105,6 +105,7 @@ source "drivers/phy/allwinner/Kconfig"
> source "drivers/phy/amlogic/Kconfig"
> source "drivers/phy/broadcom/Kconfig"
> source "drivers/phy/cadence/Kconfig"
> +source "drivers/phy/eswin/Kconfig"
> source "drivers/phy/freescale/Kconfig"
> source "drivers/phy/hisilicon/Kconfig"
> source "drivers/phy/ingenic/Kconfig"
> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
> index bfb27fb5a494..482a143d3417 100644
> --- a/drivers/phy/Makefile
> +++ b/drivers/phy/Makefile
> @@ -17,6 +17,7 @@ obj-y += allwinner/ \
> amlogic/ \
> broadcom/ \
> cadence/ \
> + eswin/ \
> freescale/ \
> hisilicon/ \
> ingenic/ \
> diff --git a/drivers/phy/eswin/Kconfig b/drivers/phy/eswin/Kconfig
> new file mode 100644
> index 000000000000..37447cc3af63
> --- /dev/null
> +++ b/drivers/phy/eswin/Kconfig
> @@ -0,0 +1,14 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# Phy drivers for ESWIN platforms
> +#
> +config PHY_EIC7700_SATA
> + tristate "eic7700 Sata SerDes/PHY driver"
> + depends on ARCH_ESWIN || COMPILE_TEST
> + depends on HAS_IOMEM
> + select GENERIC_PHY
> + help
> + Enable this to support SerDes/Phy found on ESWIN's
> + EIC7700 SoC.This Phy supports SATA 1.5 Gb/s,
> + SATA 3.0 Gb/s, SATA 6.0 Gb/s speeds.
> + It supports one SATA host port to accept one SATA device.
> diff --git a/drivers/phy/eswin/Makefile b/drivers/phy/eswin/Makefile
> new file mode 100644
> index 000000000000..db08c66be812
> --- /dev/null
> +++ b/drivers/phy/eswin/Makefile
> @@ -0,0 +1,2 @@
> +# SPDX-License-Identifier: GPL-2.0
> +obj-$(CONFIG_PHY_EIC7700_SATA) += phy-eic7700-sata.o
> diff --git a/drivers/phy/eswin/phy-eic7700-sata.c b/drivers/phy/eswin/phy-eic7700-sata.c
> new file mode 100644
> index 000000000000..96ae62a1b637
> --- /dev/null
> +++ b/drivers/phy/eswin/phy-eic7700-sata.c
> @@ -0,0 +1,221 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * ESWIN SATA PHY driver
> + *
> + * Copyright 2026, Beijing ESWIN Computing Technology Co., Ltd..
> + * All rights reserved.
> + *
> + * Authors: Yulin Lu <luyulin@...incomputing.com>
> + */
> +
> +#include <linux/bitfield.h>
> +#include <linux/clk.h>
> +#include <linux/delay.h>
> +#include <linux/io.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/phy/phy.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +#include <linux/reset.h>
> +
> +#define SATA_AXI_LP_CTRL 0x08
> +#define SATA_MPLL_CTRL 0x20
> +#define SATA_P0_PHY_STAT 0x24
> +#define SATA_PHY_CTRL0 0x28
> +#define SATA_PHY_CTRL1 0x2c
> +#define SATA_REF_CTRL 0x34
> +#define SATA_REF_CTRL1 0x38
> +#define SATA_LOS_IDEN 0x3c
> +
> +#define SATA_CLK_RST_SOURCE_PHY BIT(0)
> +#define SATA_P0_PHY_TX_AMPLITUDE_GEN1_MASK GENMASK(6, 0)
> +#define SATA_P0_PHY_TX_AMPLITUDE_GEN2_MASK GENMASK(14, 8)
> +#define SATA_P0_PHY_TX_AMPLITUDE_GEN3_MASK GENMASK(22, 16)
> +#define SATA_P0_PHY_TX_PREEMPH_GEN1_MASK GENMASK(5, 0)
> +#define SATA_P0_PHY_TX_PREEMPH_GEN2_MASK GENMASK(13, 8)
> +#define SATA_P0_PHY_TX_PREEMPH_GEN3_MASK GENMASK(21, 16)
> +#define SATA_LOS_LEVEL_MASK GENMASK(4, 0)
> +#define SATA_LOS_BIAS_MASK GENMASK(18, 16)
> +#define SATA_M_CSYSREQ BIT(0)
> +#define SATA_S_CSYSREQ BIT(16)
> +#define SATA_REF_REPEATCLK_EN BIT(0)
> +#define SATA_REF_USE_PAD BIT(20)
> +#define SATA_MPLL_MULTIPLIER_MASK GENMASK(22, 16)
> +#define SATA_P0_PHY_READY BIT(0)
> +
> +#define PLL_LOCK_SLEEP_US 10
> +#define PLL_LOCK_TIMEOUT_US 1000
> +
> +struct eic7700_sata_phy {
> + struct reset_control *rst;
> + struct regmap *regmap;
> + struct clk *clk;
> + struct phy *phy;
> +};
> +
> +static const struct regmap_config eic7700_sata_phy_regmap_config = {
> + .reg_bits = 32,
> + .val_bits = 32,
> + .reg_stride = 4,
> + .max_register = SATA_LOS_IDEN,
> +};
> +
> +static int wait_for_phy_ready(struct regmap *regmap, u32 reg, u32 checkbit,
> + u32 status)
> +{
> + u32 val;
> + int ret;
> +
> + ret = regmap_read_poll_timeout(regmap, reg, val,
> + (val & checkbit) == status,
> + PLL_LOCK_SLEEP_US, PLL_LOCK_TIMEOUT_US);
> +
> + return ret;
> +}
> +
> +static int eic7700_sata_phy_init(struct phy *phy)
> +{
> + struct eic7700_sata_phy *sata_phy = phy_get_drvdata(phy);
> + u32 val;
> + int ret;
> +
> + ret = clk_prepare_enable(sata_phy->clk);
> + if (ret)
> + return ret;
> +
> + regmap_write(sata_phy->regmap, SATA_REF_CTRL1, SATA_CLK_RST_SOURCE_PHY);
> +
> + val = FIELD_PREP(SATA_P0_PHY_TX_AMPLITUDE_GEN1_MASK, 0x42) |
> + FIELD_PREP(SATA_P0_PHY_TX_AMPLITUDE_GEN2_MASK, 0x46) |
> + FIELD_PREP(SATA_P0_PHY_TX_AMPLITUDE_GEN3_MASK, 0x73);
> + regmap_write(sata_phy->regmap, SATA_PHY_CTRL0, val);
> +
> + val = FIELD_PREP(SATA_P0_PHY_TX_PREEMPH_GEN1_MASK, 0x5) |
> + FIELD_PREP(SATA_P0_PHY_TX_PREEMPH_GEN2_MASK, 0x5) |
> + FIELD_PREP(SATA_P0_PHY_TX_PREEMPH_GEN3_MASK, 0x8);
Where are the magic values you are writing coming from..?
> + regmap_write(sata_phy->regmap, SATA_PHY_CTRL1, val);
> +
> + val = FIELD_PREP(SATA_LOS_LEVEL_MASK, 0x9) |
> + FIELD_PREP(SATA_LOS_BIAS_MASK, 0x2);
> + regmap_write(sata_phy->regmap, SATA_LOS_IDEN, val);
> +
> + val = SATA_M_CSYSREQ | SATA_S_CSYSREQ;
> + regmap_write(sata_phy->regmap, SATA_AXI_LP_CTRL, val);
> +
> + val = SATA_REF_REPEATCLK_EN | SATA_REF_USE_PAD;
> + regmap_write(sata_phy->regmap, SATA_REF_CTRL, val);
> +
> + val = FIELD_PREP(SATA_MPLL_MULTIPLIER_MASK, 0x3c);
> + regmap_write(sata_phy->regmap, SATA_MPLL_CTRL, val);
> +
> + usleep_range(15, 20);
> +
> + ret = reset_control_deassert(sata_phy->rst);
> + if (ret)
> + goto disable_clk;
> +
> + ret = wait_for_phy_ready(sata_phy->regmap, SATA_P0_PHY_STAT,
> + SATA_P0_PHY_READY, 1);
> + if (ret < 0) {
> + dev_err(&sata_phy->phy->dev, "PHY READY check failed\n");
> + goto disable_clk;
> + }
> +
> + return 0;
> +
> +disable_clk:
> + clk_disable_unprepare(sata_phy->clk);
> + return ret;
> +}
> +
> +static int eic7700_sata_phy_exit(struct phy *phy)
> +{
> + struct eic7700_sata_phy *sata_phy = phy_get_drvdata(phy);
> + int ret;
> +
> + ret = reset_control_assert(sata_phy->rst);
> + if (ret)
> + return ret;
> +
> + clk_disable_unprepare(sata_phy->clk);
> +
> + return 0;
> +}
> +
> +static const struct phy_ops eic7700_sata_phy_ops = {
> + .init = eic7700_sata_phy_init,
> + .exit = eic7700_sata_phy_exit,
> + .owner = THIS_MODULE,
> +};
> +
> +static int eic7700_sata_phy_probe(struct platform_device *pdev)
> +{
> + struct eic7700_sata_phy *sata_phy;
> + struct phy_provider *phy_provider;
> + struct device *dev = &pdev->dev;
> + struct resource *res;
> + void __iomem *regs;
> +
> + sata_phy = devm_kzalloc(dev, sizeof(*sata_phy), GFP_KERNEL);
> + if (!sata_phy)
> + return -ENOMEM;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res)
> + return -ENOENT;
> +
> + regs = devm_ioremap(dev, res->start, resource_size(res));
> + if (IS_ERR(regs))
> + return PTR_ERR(regs);
devm_platform_get_and_ioremap_resource() please
--
~Vinod
Powered by blists - more mailing lists