linux-kernel - Re: [PATCH v5 1/6] dt-bindings: gpio-mmio: Correct opencores GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bb9de0d-f811-45ff-b673-8811540b5376@kernel.org>
Date: Wed, 14 Jan 2026 16:43:35 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stafford Horne <shorne@...il.com>, LKML <linux-kernel@...r.kernel.org>
Cc: Linux OpenRISC <linux-openrisc@...r.kernel.org>,
 devicetree <devicetree@...r.kernel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Linus Walleij <linusw@...nel.org>,
 Bartosz Golaszewski <brgl@...nel.org>, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v5 1/6] dt-bindings: gpio-mmio: Correct opencores GPIO

On 14/01/2026 16:13, Stafford Horne wrote:
> In commit f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible
> string for opencores,gpio") we marked opencores,gpio to be allowed with
> brcm,bcm6345-gpio. This was wrong, opencores,gpio is not hardware
> equivalent to brcm,bcm6345-gpio. It has a different register map and

"is not compatible with brcm,...."


> is 8-bit vs braodcom which is 32-bit.  Change opencores,gpio to be a
> separate compatible string for MMIO GPIO.
> 
> Fixes: f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible string for opencores,gpio")
> Signed-off-by: Stafford Horne <shorne@...il.com>
> ---
> Since v4:
>  - New patch.
>  - Rebased old patch and rewrote commit message.
> 
>  .../devicetree/bindings/gpio/gpio-mmio.yaml      | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> index 7ee40b9bc562..a8823ca65e78 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-mmio.yaml
> @@ -18,16 +18,12 @@ description:
>  
>  properties:
>    compatible:
> -    oneOf:
> -      - enum:
> -          - brcm,bcm6345-gpio
> -          - ni,169445-nand-gpio
> -          - wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller
> -          - intel,ixp4xx-expansion-bus-mmio-gpio
> -      - items:
> -          - enum:
> -              - opencores,gpio
> -          - const: brcm,bcm6345-gpio
> +    enum:
> +      - brcm,bcm6345-gpio
> +      - ni,169445-nand-gpio
> +      - wd,mbl-gpio # Western Digital MyBook Live memory-mapped GPIO controller
> +      - intel,ixp4xx-expansion-bus-mmio-gpio
> +      - opencores,gpio

So if you are changing all of the lines here, you can as well sort it
and put the new entry not at the end but in alphabetical spot.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Best regards,
Krzysztof