linux-kernel - Re: [RFC PATCH v4 02/28] sched/deadline: Distinct between dl_rq and my

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWfACh9voa3Nk-pA@jlelli-thinkpadt14gen4.remote.csb>
Date: Wed, 14 Jan 2026 17:10:50 +0100
From: Juri Lelli <juri.lelli@...hat.com>
To: Yuri Andriaccio <yurand2000@...il.com>
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	linux-kernel@...r.kernel.org,
	Luca Abeni <luca.abeni@...tannapisa.it>,
	Yuri Andriaccio <yuri.andriaccio@...tannapisa.it>
Subject: Re: [RFC PATCH v4 02/28] sched/deadline: Distinct between dl_rq and
 my_q

Hello,

Think we want s/Distinct/Distinguish/ in $SUBJECT.

On 01/12/25 13:41, Yuri Andriaccio wrote:
> From: luca abeni <luca.abeni@...tannapisa.it>
> 
> Split the single runqueue pointer in sched_dl_entity into two separate
> pointers, following the existing pattern used by sched_rt_entity:
> 
> - dl_rq: Points to the deadline runqueue where this entity is queued
>          (global runqueue).
> - my_q:  Points to the runqueue that this entity serves (for servers).
> 
> This distinction is currently redundant for the fair_server (both point
> to the same CPU's structures), but is essential for future RT cgroup
> support where deadline servers will be queued on the global dl_rq while
> serving tasks from cgroup-specific runqueues.
> 
> Update rq_of_dl_se() to use container_of() to recover the global rq from
> dl_rq, and update fair.c to explicitly use my_q (local rq) when accessing
> the served runqueue.
> 
> Update dl_server_init() to take a dl_rq pointer (use to retrieve the
> global runqueue where the dl_server is scheduled) and a rq pointer (for
> the local runqueue served by the server).
> 
> Signed-off-by: luca abeni <luca.abeni@...tannapisa.it>
> Signed-off-by: Yuri Andriaccio <yurand2000@...il.com>

Reviewed-by: Juri Lelli <juri.lelli@...hat.com>

Thanks,
Juri