linux-kernel - Re: [PATCH v4] ACPI: bus: Align acpi_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jbAp0ANtJ9XE1ot4g6UHoYGSY9djq4_MvkYvM34+t4mw@mail.gmail.com>
Date: Wed, 14 Jan 2026 17:17:56 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>, Kartik Rajput <kkartik@...dia.com>
Cc: mika.westerberg@...ux.intel.com, andriy.shevchenko@...ux.intel.com, 
	thierry.reding@...il.com, jonathanh@...dia.com, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] ACPI: bus: Align acpi_device_get_match_data() with
 driver match order

On Wed, Jan 14, 2026 at 10:14 AM Sakari Ailus
<sakari.ailus@...ux.intel.com> wrote:
>
> Hi Kartik,
>
> On Wed, Jan 14, 2026 at 01:53:06PM +0530, Kartik Rajput wrote:
> > During pre-production development, drivers may provide both ACPI and OF
> > match tables while a formal ACPI HID for the device is not yet
> > allocated. Such devices are enumerated via PRP0001. In this case,
> > acpi_device_get_match_data() consults only the driver’s ACPI match table
> > and returns NULL, even though the device was successfully matched via
> > PRP0001.
> >
> > This behavior also risks breaking existing PRP0001 setups if a driver
> > later gains an ACPI HID, as the presence of an ACPI match table changes
> > the match-data lookup path.
> >
> > Make acpi_device_get_match_data() use the same precedence as driver
> > matching by using __acpi_match_device(). Return match data from the
> > acpi_id or of_id that was actually matched.
> >
> > Remove now-unused acpi_of_device_get_match_data().
> >
> > Signed-off-by: Kartik Rajput <kkartik@...dia.com>
>
> Thank you for the update, this looks really nice now.
>
> Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

Applied as 6.20 material, thanks!