linux-kernel - Re: [PATCH] backlight: aw99706: Fix build errors caused by wrong gpio header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWfB1ao4bVyRk97e@aspen.lan>
Date: Wed, 14 Jan 2026 16:18:29 +0000
From: Daniel Thompson <danielt@...nel.org>
To: Junjie Cao <junjie.cao@...el.com>
Cc: Lee Jones <lee@...nel.org>, Jingoo Han <jingoohan1@...il.com>,
	Pengyu Luo <mitltlatltl@...il.com>, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, caojunjie650@...il.com,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] backlight: aw99706: Fix build errors caused by wrong
 gpio header

On Sun, Jan 11, 2026 at 09:01:17PM +0800, Junjie Cao wrote:
> The driver uses GPIO descriptor API (devm_gpiod_get,
> gpiod_set_value_cansleep, GPIOD_OUT_LOW) but includes the legacy
> <linux/gpio.h> header instead of <linux/gpio/consumer.h>.
>
> When CONFIG_GPIOLIB is not set, <linux/gpio.h> does not include
> <linux/gpio/consumer.h>, causing build errors:
>
>   error: implicit declaration of function 'gpiod_set_value_cansleep'
>   error: implicit declaration of function 'devm_gpiod_get'
>   error: 'GPIOD_OUT_LOW' undeclared
>
> Fix by including the correct header <linux/gpio/consumer.h>.
>
> Fixes: 147b38a5ad06 ("backlight: aw99706: Add support for Awinic AW99706 backlight")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512171631.uKXlYwqu-lkp@intel.com/
> Signed-off-by: Junjie Cao <junjie.cao@...el.com>

Reviewed-by: Daniel Thompson (RISCstar) <danielt@...nel.org>


Daniel.