linux-kernel - Re: [PATCH v3] cxl: Check for invalid addresses returned from translation functions on errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWfH8NvVgb9vxfC5@rric.localdomain>
Date: Wed, 14 Jan 2026 17:44:32 +0100
From: Robert Richter <rrichter@....com>
To: Dave Jiang <dave.jiang@...el.com>
Cc: Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] cxl: Check for invalid addresses returned from
 translation functions on errors

On 14.01.26 09:08:17, Dave Jiang wrote:
> On 1/13/26 10:45 AM, Robert Richter wrote:
> > On 13.01.26 08:51:15, Dave Jiang wrote:

> >> Added user impact statement and fixed up tab formatting reported by checkpatch.
> > 
> >>> +		pr_err("test random iter %d FAIL hpa=%llu, dpa=%llu reverse_dpa=%llu, pos=%d reverse_pos=%d eiw=%u eig=%u\n",
> >>> +			i, hpa, dpa, reverse_dpa, pos, reverse_pos, eiw, eig);
> > 
> > Note that my checkpatch does not trigger a tab issue here. How did you
> > test that?
> 
> Maybe --strict?

CHECK: Alignment should match open parenthesis
#177: FILE: tools/testing/cxl/test/cxl_translate.c:275:
+               pr_err("test random iter %d FAIL hpa=%llu, dpa=%llu reverse_dpa=%llu, pos=%d reverse_pos=%d eiw=%u eig=%u\n",
+                       i, hpa, dpa, reverse_dpa, pos, reverse_pos, eiw, eig);

Got it, thanks.

-Robert