linux-kernel - Re: [PATCH 04/31] nova-core: factor .fwsignature* selection into a new get_gsp_sigs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8891f76d-4c91-4452-bad9-dfb725a58d5e@nvidia.com>
Date: Tue, 13 Jan 2026 18:24:55 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Gary Guo <gary@...yguo.net>, Danilo Krummrich <dakr@...nel.org>
Cc: Alexandre Courbot <acourbot@...dia.com>,
 Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Alistair Popple <apopple@...dia.com>, Edwin Peer <epeer@...dia.com>,
 Zhi Wang <zhiw@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>, nouveau@...ts.freedesktop.org,
 rust-for-linux@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/31] nova-core: factor .fwsignature* selection into a
 new get_gsp_sigs_section()

On 1/13/26 5:33 AM, Gary Guo wrote:
> On Wed Dec 3, 2025 at 5:58 AM GMT, John Hubbard wrote:
...
>> -        let sigs_section = match chipset.arch() {
>> -            Architecture::Ampere => ".fwsignature_ga10x",
>> -            Architecture::Hopper => ".fwsignature_gh10x",
>> -            Architecture::Ada => ".fwsignature_ad10x",
>> +    fn get_gsp_sigs_section(chipset: Chipset) -> Result<&'static str> {
> 
> I would just return `Option` here, and have
> 
>     let sigs_section = Self::get_gsp_sigs_section(chipset).ok_or(ENOTSUPP)?;
> 
> similar to the ELF line aboe it.

Nice, I'll do that.

> 
> The code looks correct to me regardless if you make the change.
> 
> Reviewed-by: Gary Guo <gary@...yguo.net>

Thanks for the review (here and elsewhere)!


thanks,
-- 
John Hubbard