linux-kernel - Re: [PATCH v2 2/5] accel/thames: Add driver for the C7x DSPs in TI SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd22f4d2-b67d-4c07-9559-2b23eb558102@web.de>
Date: Wed, 14 Jan 2026 18:02:08 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Tomeu Vizoso <tomeu@...euvizoso.net>, dri-devel@...ts.freedesktop.org,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linaro-mm-sig@...ts.linaro.org
Cc: LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org,
 Andrei Aldea <a-aldea@...com>, "Andrew F. Davis" <afd@...com>,
 Chirag Shilwant <c-shilwant@...com>,
 Christian König <christian.koenig@....com>,
 Conor Dooley <conor+dt@...nel.org>, David Airlie <airlied@...il.com>,
 Jonathan Corbet <corbet@....net>, Jonathan Humphreys <j-humphreys@...com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Nishanth Menon <nm@...com>,
 Oded Gabbay <ogabbay@...nel.org>, Randolph Sapp <rs@...com>,
 Rob Herring <robh@...nel.org>, Robert Nelson <robertcnelson@...il.com>,
 Simona Vetter <simona@...ll.ch>, Sumit Semwal <sumit.semwal@...aro.org>,
 Tero Kristo <kristo@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v2 2/5] accel/thames: Add driver for the C7x DSPs in TI
 SoCs

…
> +++ b/drivers/accel/thames/thames_drv.c
> @@ -0,0 +1,155 @@
…
> +static int thames_open(struct drm_device *dev, struct drm_file *file)
> +{
…
> +	if (!try_module_get(THIS_MODULE))
> +		return -EINVAL;
> +
> +	thames_priv = kzalloc(sizeof(*thames_priv), GFP_KERNEL);
> +	if (!thames_priv) {
> +		ret = -ENOMEM;
> +		goto err_put_mod;
> +	}
…

I find the identifiers “ret” and “err_put_mod” redundant here because the desired
exception handling can be specified in this if branch directly.

Regards,
Markus