linux-kernel - Re: [PATCH v2 6/6] vfio: selftests: Add tests to validate SR-IOV UAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWfNuFtifJZAS1a0@google.com>
Date: Wed, 14 Jan 2026 17:09:12 +0000
From: David Matlack <dmatlack@...gle.com>
To: Raghavendra Rao Ananta <rananta@...gle.com>
Cc: Alex Williamson <alex@...zbot.org>,
	Alex Williamson <alex.williamson@...hat.com>,
	Josh Hilke <jrhilke@...gle.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/6] vfio: selftests: Add tests to validate SR-IOV UAPI

On 2026-01-09 11:05 AM, Raghavendra Rao Ananta wrote:
> On Wed, Jan 7, 2026 at 3:22 PM David Matlack <dmatlack@...gle.com> wrote:
> > On 2025-12-10 06:14 PM, Raghavendra Rao Ananta wrote:

> > > +static struct vfio_pci_device *test_vfio_pci_device_init(const char *bdf,
> > > +                                                      struct iommu *iommu,
> > > +                                                      const char *vf_token,
> > > +                                                      int *out_ret)
> > > +{
> > > +     struct vfio_pci_device *device;
> > > +
> > > +     device = calloc(1, sizeof(*device));
> > > +     VFIO_ASSERT_NOT_NULL(device);
> > > +
> > > +     device->iommu = iommu;
> > > +     device->bdf = bdf;
> >
> > Can you put this in a helper exposed by vfio_pci_device.h? e.g.
> > vfio_pci_device_alloc()
> >
> Is that just to wrap the ASSERT() within? Or were you thinking of
> initializing the members as well in there?

I was thinking it would include all of the above.