linux-kernel - Re: [PATCH v9 12/13] cxl/region: Factor out code into cxl_region_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260114181756.0000364f@huawei.com>
Date: Wed, 14 Jan 2026 18:17:56 +0000
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Alison Schofield <alison.schofield@...el.com>
CC: Robert Richter <rrichter@....com>, Vishal Verma
	<vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>, Dan Williams
	<dan.j.williams@...el.com>, Dave Jiang <dave.jiang@...el.com>, "Davidlohr
 Bueso" <dave@...olabs.net>, <linux-cxl@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Gregory Price <gourry@...rry.net>, "Fabio M.
 De Francesco" <fabio.m.de.francesco@...ux.intel.com>, Terry Bowman
	<terry.bowman@....com>, Joshua Hahn <joshua.hahnjy@...il.com>
Subject: Re: [PATCH v9 12/13] cxl/region: Factor out code into
 cxl_region_setup_poison()

On Tue, 13 Jan 2026 19:32:54 -0800
Alison Schofield <alison.schofield@...el.com> wrote:

> On Sat, Jan 10, 2026 at 12:46:57PM +0100, Robert Richter wrote:
> > Poison injection setup code is embedded in cxl_region_probe(). For
> > improved encapsulation, readability, and maintainability, factor out
> > code into function cxl_region_setup_poison().
> > 
> > This patch is a prerequisit to disable poison injection for Normalized
> > Addressing.  
> 
> I prefer we be clearer about intent. Poison injection altogether is not
> being disabled, only by region offset. 
> 
> Replace this:
> > This patch is a prerequisit to disable poison injection for Normalized
> > Addressing.  
> 
> With this:
> This patch is a prerequisite to disable poison by region offset for
> Normalized Addressing.
> 
> With that,
> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
Alison's request seems sensible to me.  Otherwise looks good.
Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>

> 
> 
>